--===============1644718725== Content-Type: multipart/alternative; boundary="===============4953223653858505758==" --===============4953223653858505758== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-12-03 19:08:50, Sebastian Sauer wrote: > > Looks great. koffice/trunk is frozen (only build fixes are allowed yet)= . So, please commit in the essen-branch (if noone else has objections?). > = > Juan Aquino wrote: > Thanks Sebastian, I have no svn account, please commit for me. See http://techbase.kde.org/Contribute/Get_a_SVN_Account to get a KDE SVN-a= ccount. Can't harm to have a SVN account as long as parts of KDE are still = in svn (we are moving to git soon). I committed meanwhile the patch to branches/work/koffice-essen/kspread ( r1= 203398 ). Looks as the patch will be in 2.3.1 but not the just to be releas= ed 2.3.0 then cause 2.3.0 is already in rc-state (sorry :-/ ) - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5976/#review9116 ----------------------------------------------------------- On 2010-11-26 02:32:07, Juan Aquino wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5976/ > ----------------------------------------------------------- > = > (Updated 2010-11-26 02:32:07) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Patch for bug 240235, IF function shows wrong result, missing some compar= isons between empty and others values. > - Added comparison: > empty vs integer > empty vs float > empty vs boolean, like openoffice and excel. > = > = > This addresses bug 240235. > https://bugs.kde.org/show_bug.cgi?id=3D240235 > = > = > Diffs > ----- > = > /trunk/koffice/kspread/Value.cpp 1200862 = > /trunk/koffice/kspread/tests/TestLogicFunctions.cpp 1200862 = > = > Diff: http://svn.reviewboard.kde.org/r/5976/diff > = > = > Testing > ------- > = > test included and passed. > = > = > Thanks, > = > Juan > = > --===============4953223653858505758== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5976/

On December 3rd, 2010, 7:08 p.m., Sebastian= Sauer wrote:

Looks gre=
at. koffice/trunk is frozen (only build fixes are allowed yet). So, please =
commit in the essen-branch (if noone else has objections?).

On December 3rd, 2010, 8:02 p.m., Juan Aquino wrote:

Thanks Se=
bastian, I have no svn account, please commit for me.
See http://=
techbase.kde.org/Contribute/Get_a_SVN_Account to get a KDE SVN-account. Can=
't harm to have a SVN account as long as parts of KDE are still in svn =
(we are moving to git soon).

I committed meanwhile the patch to branches/work/koffice-essen/kspread ( r1=
203398 ). Looks as the patch will be in 2.3.1 but not the just to be releas=
ed 2.3.0 then cause 2.3.0 is already in rc-state (sorry :-/ )

- Sebastian


On November 26th, 2010, 2:32 a.m., Juan Aquino wrote:

Review request for KOffice.
By Juan Aquino.

Updated 2010-11-26 02:32:07

Descripti= on 

Patch for bug 240235, IF function shows wrong result, missin=
g some comparisons between empty and others values.
- Added comparison:
  empty vs integer
  empty vs float
  empty vs boolean, like openoffice and excel.

Testing <= /h1> 
test included and passed.
Bugs: 240235

Diffs=

  • /trunk/koffice/kspread/Value.cpp (1200862)=
  • /trunk/koffice/kspread/tests/TestLogicFunctions.cpp (1200862)

View Diff
--===============4953223653858505758==-- --===============1644718725== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1644718725==--