[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix for shape paste endless loop in Krita
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2010-10-31 13:31:27
Message-ID: 20101031133127.26535.36094 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5733/#review8451
-----------------------------------------------------------
Ship it!
Only one remark from my side.
/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h
<http://svn.reviewboard.kde.org/r/5733/#comment8807>
Is this comment invalid now?
- Boudewijn
On 2010-10-31 12:20:20, Sven Langkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5733/
> -----------------------------------------------------------
>
> (Updated 2010-10-31 12:20:20)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> The patch fixes a problem when copy and paste a shape in Krita. The problem is that \
> KoShapePaste does some calculation to have a little offset between old shape and \
> pasted shape. For that it expects that the shape isn't in the shape manager \
> (KoShapePaste line 110 and following). In Krita the shape layer model does add the \
> shape in addShape. The patch changes that so the shape is not added in the model, \
> but in KisShapeController and KisShapeLayerShapePaste.
>
> This addresses bug 255682.
> https://bugs.kde.org/show_bug.cgi?id=255682
>
>
> Diffs
> -----
>
> /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1191387
> /trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1191387
> /trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h 1191387
>
> Diff: http://svn.reviewboard.kde.org/r/5733/diff
>
>
> Testing
> -------
>
> Tested with copy and paste.
>
>
> Thanks,
>
> Sven
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5733/">http://svn.reviewboard.kde.org/r/5733/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only one remark from my \
side.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5733/diff/1/?file=40514#file40514line49" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">49</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//don't update as the setDirty call would create shared pointer that \
would delete the layer</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this \
comment invalid now?</pre> </div>
<br />
<p>- Boudewijn</p>
<br />
<p>On October 31st, 2010, 12:20 p.m., Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated 2010-10-31 12:20:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch fixes a problem when copy and paste a shape in Krita. The \
problem is that KoShapePaste does some calculation to have a little offset between \
old shape and pasted shape. For that it expects that the shape isn't in the shape \
manager (KoShapePaste line 110 and following). In Krita the shape layer model does \
add the shape in addShape. The patch changes that so the shape is not added in the \
model, but in KisShapeController and KisShapeLayerShapePaste.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with copy and paste.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=255682">255682</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp <span style="color: \
grey">(1191387)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_layer.cc <span style="color: \
grey">(1191387)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h <span style="color: \
grey">(1191387)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5733/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic