This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5733/

Ship it!

Only one remark from my side.

/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h (Diff revision 1) 
public:
49 
                    //don't update as the setDirty call would create shared pointer that would delete the layer
 

  


 





Is this comment invalid now?









- Boudewijn






On October 31st, 2010, 12:20 p.m., Sven Langkamp wrote:









 

  


Review request for KOffice.


By Sven Langkamp.




Updated 2010-10-31 12:20:20






Description 



 

  
   
The patch fixes a problem when copy and paste a shape in Krita. The problem is that KoShapePaste does some calculation to have a little offset between old shape and pasted shape. For that it expects that the shape isn't in the shape manager (KoShapePaste line 110 and following). In Krita the shape layer model does add the shape in addShape. The patch changes that so the shape is not added in the model, but in KisShapeController and KisShapeLayerShapePaste.

  		
 






Testing 



 

  
   
Tested with copy and paste.

  		
 








 Bugs: 


 255682







Diffs 


    

 
  • /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp (1191387)
    • 

 
  • /trunk/koffice/krita/ui/flake/kis_shape_layer.cc (1191387)
    • 

 
  • /trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h (1191387)
    • 





View Diff