--===============0816712961== Content-Type: multipart/alternative; boundary="===============7508881106583584935==" --===============7508881106583584935== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5733/#review8451 ----------------------------------------------------------- Ship it! Only one remark from my side. /trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h Is this comment invalid now? - Boudewijn On 2010-10-31 12:20:20, Sven Langkamp wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5733/ > ----------------------------------------------------------- > = > (Updated 2010-10-31 12:20:20) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > The patch fixes a problem when copy and paste a shape in Krita. The probl= em is that KoShapePaste does some calculation to have a little offset betwe= en old shape and pasted shape. For that it expects that the shape isn't in = the shape manager (KoShapePaste line 110 and following). In Krita the shape= layer model does add the shape in addShape. The patch changes that so the = shape is not added in the model, but in KisShapeController and KisShapeLaye= rShapePaste. > = > = > This addresses bug 255682. > https://bugs.kde.org/show_bug.cgi?id=3D255682 > = > = > Diffs > ----- > = > /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1191387 = > /trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1191387 = > /trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h 1191387 = > = > Diff: http://svn.reviewboard.kde.org/r/5733/diff > = > = > Testing > ------- > = > Tested with copy and paste. > = > = > Thanks, > = > Sven > = > --===============7508881106583584935== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5733/

Ship it!

Only one r=
emark from my side.

= =

/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h (Diff revision 1)
public:
49	//don&#= 39;t update as the setDirty call would create shared pointer that would del= ete the layer

Is this comment invalid now?

- Boudewijn

On October 31st, 2010, 12:20 p.m., Sven Langkamp wrote:

Review request for KOffice.

By Sven Langkamp.

Updated 2010-10-31 12:20:20

Descripti= on

The patch fixes a problem when copy and paste a shape in Kri=
ta. The problem is that KoShapePaste does some calculation to have a little=
 offset between old shape and pasted shape. For that it expects that the sh=
ape isn't in the shape manager (KoShapePaste line 110 and following). I=
n Krita the shape layer model does add the shape in addShape. The patch cha=
nges that so the shape is not added in the model, but in KisShapeController=
 and KisShapeLayerShapePaste.

Testing <= /h1>

Tested with copy and paste.

Bugs: 255682

Diffs=

/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp (1191387)
/trunk/koffice/krita/ui/flake/kis_shape_layer.cc (1191387)
/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h (1191387)

--===============7508881106583584935==-- --===============0816712961== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0816712961==--