[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Correct export pdf in KPresenter and allow to
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2010-10-28 4:32:07
Message-ID: 20101028043207.18286.77130 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5610/#review8405
-----------------------------------------------------------
Ship it!
Please fix the usage of m_pageProvider and the commit.
KPrPdfPrintJob::startPrinting uses a lot of common code with KoPAPrintJob:=
:startPrinting. It would be good to use some kind of strategy for the diffe=
rent parts, then the code can even be smaller. But that is something for a =
later time.
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp
<http://svn.reviewboard.kde.org/r/5610/#comment8726>
you need to call =
=
m_pageProvider->setPageData(i + 1, page);
=
so that the correct page numbers are shown on the page.
- Thorsten
On 2010-10-26 21:01:05, Benjamin Port wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5610/
> -----------------------------------------------------------
> =
> (Updated 2010-10-26 21:01:05)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> BUG:241245
> This patch correct the bug 214245, when we export to pdf in KPresenter, n=
ow the page size is slide size.
> With the new methods to export to pdf, each KOffice application can choos=
e to kept the old export feature (just print), or implement a specific oper=
ation for export pdf.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/kpresenter/part/CMakeLists.txt 1190045 =
> /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h PRE-CREATION =
> /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp PRE-CREATION =
> /trunk/koffice/kpresenter/part/KPrView.h 1190045 =
> /trunk/koffice/kpresenter/part/KPrView.cpp 1190045 =
> /trunk/koffice/libs/kopageapp/KoPAPrintJob.h 1190045 =
> /trunk/koffice/libs/main/KoMainWindow.cpp 1190045 =
> /trunk/koffice/libs/main/KoView.h 1190045 =
> /trunk/koffice/libs/main/KoView.cpp 1190045 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5610/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Benjamin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5610/">http://svn.reviewboard.kde.org/r/5610/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please fix the usage of \
m_pageProvider and the commit.
KPrPdfPrintJob::startPrinting uses a lot of common code with \
KoPAPrintJob::startPrinting. It would be good to use some kind of strategy for the \
different parts, then the code can even be smaller. But that is something for a later \
time.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5610/diff/3/?file=40263#file40263line67" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void KPrPdfPrintJob::startPrinting(RemovePolicy removePolicy)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">67</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">painter</span><span class="p">.</span><span class="n">translate</span><span \
class="p">(</span> <span class="n">pageRect</span><span class="p">.</span><span \
class="n">topLeft</span><span class="p">()</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you need to \
call
m_pageProvider->setPageData(i + 1, page);
so that the correct page numbers are shown on the page.</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On October 26th, 2010, 9:01 p.m., Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated 2010-10-26 21:01:05</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">BUG:241245 This patch correct the bug 214245, when we export to pdf in \
KPresenter, now the page size is slide size. With the new methods to export to pdf, \
each KOffice application can choose to kept the old export feature (just print), or \
implement a specific operation for export pdf.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kpresenter/part/CMakeLists.txt <span style="color: \
grey">(1190045)</span></li>
<li>/trunk/koffice/kpresenter/part/KPrPdfPrintJob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/koffice/kpresenter/part/KPrView.h <span style="color: \
grey">(1190045)</span></li>
<li>/trunk/koffice/kpresenter/part/KPrView.cpp <span style="color: \
grey">(1190045)</span></li>
<li>/trunk/koffice/libs/kopageapp/KoPAPrintJob.h <span style="color: \
grey">(1190045)</span></li>
<li>/trunk/koffice/libs/main/KoMainWindow.cpp <span style="color: \
grey">(1190045)</span></li>
<li>/trunk/koffice/libs/main/KoView.h <span style="color: \
grey">(1190045)</span></li>
<li>/trunk/koffice/libs/main/KoView.cpp <span style="color: \
grey">(1190045)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5610/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic