From koffice-devel Thu Oct 28 04:32:07 2010 From: "Thorsten Zachmann" Date: Thu, 28 Oct 2010 04:32:07 +0000 To: koffice-devel Subject: Re: Review Request: Correct export pdf in KPresenter and allow to Message-Id: <20101028043207.18286.77130 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128824042828704 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1852632060==" --===============1852632060== Content-Type: multipart/alternative; boundary="===============1938889408793355594==" --===============1938889408793355594== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5610/#review8405 ----------------------------------------------------------- Ship it! Please fix the usage of m_pageProvider and the commit. KPrPdfPrintJob::startPrinting uses a lot of common code with KoPAPrintJob:= :startPrinting. It would be good to use some kind of strategy for the diffe= rent parts, then the code can even be smaller. But that is something for a = later time. /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp you need to call = = m_pageProvider->setPageData(i + 1, page); = so that the correct page numbers are shown on the page. - Thorsten On 2010-10-26 21:01:05, Benjamin Port wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5610/ > ----------------------------------------------------------- > = > (Updated 2010-10-26 21:01:05) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > BUG:241245 > This patch correct the bug 214245, when we export to pdf in KPresenter, n= ow the page size is slide size. > With the new methods to export to pdf, each KOffice application can choos= e to kept the old export feature (just print), or implement a specific oper= ation for export pdf. > = > = > Diffs > ----- > = > /trunk/koffice/kpresenter/part/CMakeLists.txt 1190045 = > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h PRE-CREATION = > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp PRE-CREATION = > /trunk/koffice/kpresenter/part/KPrView.h 1190045 = > /trunk/koffice/kpresenter/part/KPrView.cpp 1190045 = > /trunk/koffice/libs/kopageapp/KoPAPrintJob.h 1190045 = > /trunk/koffice/libs/main/KoMainWindow.cpp 1190045 = > /trunk/koffice/libs/main/KoView.h 1190045 = > /trunk/koffice/libs/main/KoView.cpp 1190045 = > = > Diff: http://svn.reviewboard.kde.org/r/5610/diff > = > = > Testing > ------- > = > = > Thanks, > = > Benjamin > = > --===============1938889408793355594== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5610/

Ship it!

Please fix=
 the usage of m_pageProvider and the commit.

 KPrPdfPrintJob::startPrinting uses a lot of common code with KoPAPrintJob:=
:startPrinting. It would be good to use some kind of strategy for the diffe=
rent parts, then the code can even be smaller. But that is something for a =
later time.

= =

/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (Diff revision 3)
	void KPrPdfPrintJob::startPrinting(RemovePolicy removePolicy) =
		67	painter.translate( pageRect.topLeft() );

you need to call =


m_pageProvider->setPageData(i + 1, page);

so that the correct page numbers are shown on the page.

- Thorsten

On October 26th, 2010, 9:01 p.m., Benjamin Port wrote:

Review request for KOffice.

By Benjamin Port.

Updated 2010-10-26 21:01:05

Descripti= on

BUG:241245
This patch correct the bug 214245, when we export to pdf in KPresenter, now=
 the page size is slide size.
With the new methods to export to pdf, each KOffice application can choose =
to kept the old export feature (just print), or implement a specific operat=
ion for export pdf.

Diffs=

/trunk/koffice/kpresenter/part/CMakeLists.txt (1190045)
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.h (PRE-CREATION)
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (PRE-CREATION)
/trunk/koffice/kpresenter/part/KPrView.h (= 1190045)
/trunk/koffice/kpresenter/part/KPrView.cpp (1190045)
/trunk/koffice/libs/kopageapp/KoPAPrintJob.h (1190045)
/trunk/koffice/libs/main/KoMainWindow.cpp = (1190045)
/trunk/koffice/libs/main/KoView.h (1190045= )
/trunk/koffice/libs/main/KoView.cpp (11900= 45)

--===============1938889408793355594==-- --===============1852632060== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1852632060==--