This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5610/

Ship it!

Please fix the usage of m_pageProvider and the commit.

 KPrPdfPrintJob::startPrinting uses a lot of common code with KoPAPrintJob::startPrinting. It would be good to use some kind of strategy for the different parts, then the code can even be smaller. But that is something for a later time.

/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (Diff revision 3)
		void KPrPdfPrintJob::startPrinting(RemovePolicy removePolicy)
		67	painter.translate( pageRect.topLeft() );

you need to call 

m_pageProvider->setPageData(i + 1, page);

so that the correct page numbers are shown on the page.

- Thorsten

On October 26th, 2010, 9:01 p.m., Benjamin Port wrote:

Review request for KOffice.

By Benjamin Port.

Updated 2010-10-26 21:01:05

Description

BUG:241245
This patch correct the bug 214245, when we export to pdf in KPresenter, now the page size is slide size.
With the new methods to export to pdf, each KOffice application can choose to kept the old export feature (just print), or implement a specific operation for export pdf.

Diffs

/trunk/koffice/kpresenter/part/CMakeLists.txt (1190045)
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.h (PRE-CREATION)
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (PRE-CREATION)
/trunk/koffice/kpresenter/part/KPrView.h (1190045)
/trunk/koffice/kpresenter/part/KPrView.cpp (1190045)
/trunk/koffice/libs/kopageapp/KoPAPrintJob.h (1190045)
/trunk/koffice/libs/main/KoMainWindow.cpp (1190045)
/trunk/koffice/libs/main/KoView.h (1190045)
/trunk/koffice/libs/main/KoView.cpp (1190045)

View Diff