'Re: Review Request: Remove usage of hasAttributeNS'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Remove usage of hasAttributeNS
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-10-22 9:24:36
Message-ID: 20101022092436.10635.12719 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5670/#review8300
-----------------------------------------------------------

Ship it!

Looks good, ship it.

- Boudewijn

On 2010-10-20 13:36:12, Thorsten Zachmann wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5670/
> -----------------------------------------------------------
> =

> (Updated 2010-10-20 13:36:12)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Optimize the code to use attributeNS directly without the use of hasAttri=
buteNS. That removes the need for a second lookup which is much more expens=
ive then checking if the return value was empty.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1186972 =

>   trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1186972 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5670/diff
> =

> =

> Testing
> -------
> =

> Function is the same as before the patch.
> =

> =

> Thanks,
> =

> Thorsten
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5670/">http://svn.reviewboard.kde.org/r/5670/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, ship \
it.</pre>  <br />

<p>- Boudewijn</p>

<br />
<p>On October 20th, 2010, 1:36 p.m., Thorsten Zachmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>

<p style="color: grey;"><i>Updated 2010-10-20 13:36:12</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Optimize the code to use attributeNS directly without the use of \
hasAttributeNS. That removes the need for a second lookup which is much more \
expensive then checking if the return value was empty.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Function is the same as before the patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1186972)</span></li>

 <li>trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp <span style="color: \
grey">(1186972)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5670/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 