From koffice-devel Fri Oct 22 09:24:36 2010 From: "Boudewijn Rempt" Date: Fri, 22 Oct 2010 09:24:36 +0000 To: koffice-devel Subject: Re: Review Request: Remove usage of hasAttributeNS Message-Id: <20101022092436.10635.12719 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128774056116935 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0646671760==" --===============0646671760== Content-Type: multipart/alternative; boundary="===============0941907520448745408==" --===============0941907520448745408== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5670/#review8300 ----------------------------------------------------------- Ship it! Looks good, ship it. - Boudewijn On 2010-10-20 13:36:12, Thorsten Zachmann wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5670/ > ----------------------------------------------------------- > = > (Updated 2010-10-20 13:36:12) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Optimize the code to use attributeNS directly without the use of hasAttri= buteNS. That removes the need for a second lookup which is much more expens= ive then checking if the return value was empty. > = > = > Diffs > ----- > = > trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1186972 = > trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1186972 = > = > Diff: http://svn.reviewboard.kde.org/r/5670/diff > = > = > Testing > ------- > = > Function is the same as before the patch. > = > = > Thanks, > = > Thorsten > = > --===============0941907520448745408== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5670/

Ship it!

Looks good=
, ship it.

- Boudewijn

On October 20th, 2010, 1:36 p.m., Thorsten Zachmann wrote:

Review request for KOffice.

By Thorsten Zachmann.

Updated 2010-10-20 13:36:12

Descripti= on

Optimize the code to use attributeNS directly without the us=
e of hasAttributeNS. That removes the need for a second lookup which is muc=
h more expensive then checking if the return value was empty.

Testing <= /h1>

Function is the same as before the patch.

Diffs=

trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp (1186972)
trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp (1186972)

View Diff

--===============0941907520448745408==-- --===============0646671760== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0646671760==--