'Re: Review Request: patch to add percentage symbol on axis for'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: patch to add percentage symbol on axis for
From:       "Johannes Simon" <johannes.simon () gmail ! com>
Date:       2010-10-22 9:30:59
Message-ID: 20101022093059.10768.53646 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5535/#review8301
-----------------------------------------------------------

Ship it!

With the addition mentioned in the comment, the patch looks good.

/trunk/koffice/plugins/chartshape/Axis.cpp
<http://svn.reviewboard.kde.org/r/5535/#comment8573>

    Don't forget to set the unit suffix back to "" for StackedChartType and=
 PercentChartType.

- Johannes

On 2010-10-22 08:28:32, Pavol Korinek wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5535/
> -----------------------------------------------------------
> =

> (Updated 2010-10-22 08:28:32)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> patch to add percentage symbol on axis for percentage bar diagram
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/plugins/chartshape/Axis.cpp 1188354 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5535/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Pavol
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5535/">http://svn.reviewboard.kde.org/r/5535/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With the addition \
mentioned in the comment, the patch looks good.</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5535/diff/2/?file=39899#file39899line474" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/plugins/chartshape/Axis.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Axis::Private::createBarDiagram()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">474</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">474</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">kdBarDiagram</span><span class="o">-&gt;</span><span \
class="n">setUnitSuffix</span><span class="p">(</span><span \
class="s">&quot;%&quot;</span><span class="p">,</span> <span \
class="n">kdBarDiagram</span><span class="o">-&gt;</span><span \
class="n">orientation</span><span class="p">());</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don&#39;t \
forget to set the unit suffix back to &quot;&quot; for StackedChartType and \
PercentChartType.</pre> </div>
<br />

<p>- Johannes</p>

<br />
<p>On October 22nd, 2010, 8:28 a.m., Pavol Korinek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>

<p style="color: grey;"><i>Updated 2010-10-22 08:28:32</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">patch to add percentage symbol on axis for percentage bar diagram</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/plugins/chartshape/Axis.cpp <span style="color: \
grey">(1188354)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5535/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 