--===============0522986649== Content-Type: multipart/alternative; boundary="===============9209085466478348361==" --===============9209085466478348361== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5535/#review8301 ----------------------------------------------------------- Ship it! With the addition mentioned in the comment, the patch looks good. /trunk/koffice/plugins/chartshape/Axis.cpp Don't forget to set the unit suffix back to "" for StackedChartType and= PercentChartType. - Johannes On 2010-10-22 08:28:32, Pavol Korinek wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5535/ > ----------------------------------------------------------- > = > (Updated 2010-10-22 08:28:32) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > patch to add percentage symbol on axis for percentage bar diagram > = > = > Diffs > ----- > = > /trunk/koffice/plugins/chartshape/Axis.cpp 1188354 = > = > Diff: http://svn.reviewboard.kde.org/r/5535/diff > = > = > Testing > ------- > = > = > Thanks, > = > Pavol > = > --===============9209085466478348361== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5535/

Ship it!

With the a=
ddition mentioned in the comment, the patch looks good.

= =

/trunk/koffice/plugins/chartshape/Axis.cpp (Diff revision 2)
void Axis::Private::createBarDiagram()
474		474	kdBarDiagram<= span class=3D"o">->setUnitSuffix("%",= kdBarDiagram->= orientation());

Don't forget to set the unit suffix back to "" for Sta=
ckedChartType and PercentChartType.

- Johannes

On October 22nd, 2010, 8:28 a.m., Pavol Korinek wrote:

Review request for KOffice.

By Pavol Korinek.

Updated 2010-10-22 08:28:32

Descripti= on

patch to add percentage symbol on axis for percentage bar di=
agram

Diffs=

/trunk/koffice/plugins/chartshape/Axis.cpp (1188354)

View Diff

--===============9209085466478348361==-- --===============0522986649== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0522986649==--