[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fix bug: not working mouse middle and right click
From: "Adam C." <nospam () xibo ! at>
Date: 2010-09-30 14:13:31
Message-ID: 20100930141331.17306.33280 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-30 11:16:11, Cyrille Berger wrote:
> > I am a bit concern by the side effect of this patch. Have you test what=
happen if you right- (or modifier1-) click while drawing with the freehand=
tool ?
> > =
> > Also my tablets (I haven't try with my wacom recently, but with the x61=
t) generates a mousepress and mouserelease events when the buttons are used=
, we have code to handle those in Krita, I haven't investigate why it does =
not work as expected, but I think it is a better alternative.
> =
> Cyrille Berger wrote:
> My appologize, it used to work like this, but does not anymore. Which=
makes me think that the best course of action would be to actually patch Q=
t to add support for this in QTabletEvent.
i will look into the side effects. currently i don't know, what happens, be=
cause they shouldn't be rejected if the pressure is greater than zero and t=
herefore it should take the old codepath.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5478/#review7901
-----------------------------------------------------------
On 2010-09-29 15:35:42, Adam wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5478/
> -----------------------------------------------------------
> =
> (Updated 2010-09-29 15:35:42)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> QTabletEvent has no information about which button was pressed on the sty=
lus. We have to reject it, so that it gets resent as a QMouseEvent with the=
correct buttons.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/libs/flake/KoToolProxy.cpp 1180634 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5478/diff
> =
> =
> Testing
> -------
> =
> panning and popup palette in krita works now.
> =
> =
> Thanks,
> =
> Adam
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5478/">http://svn.reviewboard.kde.org/r/5478/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 30th, 2010, 11:16 a.m., <b>Cyrille \
Berger</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I am a bit concern by the side effect of this patch. Have you test what \
happen if you right- (or modifier1-) click while drawing with the freehand tool ?
Also my tablets (I haven't try with my wacom recently, but with the x61t) \
generates a mousepress and mouserelease events when the buttons are used, we have \
code to handle those in Krita, I haven't investigate why it does not work as \
expected, but I think it is a better alternative.</pre> </blockquote>
<p>On September 30th, 2010, 1:48 p.m., <b>Cyrille Berger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My appologize, it used \
to work like this, but does not anymore. Which makes me think that the best course of \
action would be to actually patch Qt to add support for this in QTabletEvent.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i will look into the \
side effects. currently i don't know, what happens, because they shouldn't be \
rejected if the pressure is greater than zero and therefore it should take the old \
codepath.</pre> <br />
<p>- Adam</p>
<br />
<p>On September 29th, 2010, 3:35 p.m., Adam wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam.</div>
<p style="color: grey;"><i>Updated 2010-09-29 15:35:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QTabletEvent has no information about which button was pressed on the \
stylus. We have to reject it, so that it gets resent as a QMouseEvent with the \
correct buttons.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">panning and popup palette in krita works now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/flake/KoToolProxy.cpp <span style="color: \
grey">(1180634)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5478/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic