This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5478/

On September 30th, 2010, 11:16 a.m., Cyrille Berger wrote:

I am a bit concern by the side effect of this patch. Have you test what happen if you right- (or modifier1-) click while drawing with the freehand tool ?

Also my tablets (I haven't try with my wacom recently, but with the x61t) generates a mousepress and mouserelease events when the buttons are used, we have code to handle those in Krita, I haven't investigate why it does not work as expected, but I think it is a better alternative.

On September 30th, 2010, 1:48 p.m., Cyrille Berger wrote:

My appologize, it used to work like this, but does not anymore. Which makes me think that the best course of action would be to actually patch Qt to add support for this in QTabletEvent.
i will look into the side effects. currently i don't know, what happens, because they shouldn't be rejected if the pressure is greater than zero and therefore it should take the old codepath.

- Adam


On September 29th, 2010, 3:35 p.m., Adam wrote:

Review request for KOffice.
By Adam.

Updated 2010-09-29 15:35:42

Description

QTabletEvent has no information about which button was pressed on the stylus. We have to reject it, so that it gets resent as a QMouseEvent with the correct buttons.

Testing

panning and popup palette in krita works now.

Diffs

  • /trunk/koffice/libs/flake/KoToolProxy.cpp (1180634)

View Diff