From koffice-devel Thu Sep 30 14:13:31 2010 From: "Adam C." Date: Thu, 30 Sep 2010 14:13:31 +0000 To: koffice-devel Subject: Re: Review Request: fix bug: not working mouse middle and right click Message-Id: <20100930141331.17306.33280 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128585606009005 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1304890080==" --===============1304890080== Content-Type: multipart/alternative; boundary="===============4137881751906459231==" --===============4137881751906459231== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-09-30 11:16:11, Cyrille Berger wrote: > > I am a bit concern by the side effect of this patch. Have you test what= happen if you right- (or modifier1-) click while drawing with the freehand= tool ? > > = > > Also my tablets (I haven't try with my wacom recently, but with the x61= t) generates a mousepress and mouserelease events when the buttons are used= , we have code to handle those in Krita, I haven't investigate why it does = not work as expected, but I think it is a better alternative. > = > Cyrille Berger wrote: > My appologize, it used to work like this, but does not anymore. Which= makes me think that the best course of action would be to actually patch Q= t to add support for this in QTabletEvent. i will look into the side effects. currently i don't know, what happens, be= cause they shouldn't be rejected if the pressure is greater than zero and t= herefore it should take the old codepath. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5478/#review7901 ----------------------------------------------------------- On 2010-09-29 15:35:42, Adam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5478/ > ----------------------------------------------------------- > = > (Updated 2010-09-29 15:35:42) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > QTabletEvent has no information about which button was pressed on the sty= lus. We have to reject it, so that it gets resent as a QMouseEvent with the= correct buttons. > = > = > Diffs > ----- > = > /trunk/koffice/libs/flake/KoToolProxy.cpp 1180634 = > = > Diff: http://svn.reviewboard.kde.org/r/5478/diff > = > = > Testing > ------- > = > panning and popup palette in krita works now. > = > = > Thanks, > = > Adam > = > --===============4137881751906459231== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5478/

On September 30th, 2010, 11:16 a.m., Cyrill= e Berger wrote:

I am a bi=
t concern by the side effect of this patch. Have you test what happen if yo=
u right- (or modifier1-) click while drawing with the freehand tool ?

Also my tablets (I haven't try with my wacom recently, but with the x61=
t) generates a mousepress and mouserelease events when the buttons are used=
, we have code to handle those in Krita, I haven't investigate why it d=
oes not work as expected, but I think it is a better alternative.

On September 30th, 2010, 1:48 p.m., Cyrille Berger wrote:

My appolo=
gize, it used to work like this, but does not anymore. Which makes me think=
 that the best course of action would be to actually patch Qt to add suppor=
t for this in QTabletEvent.
i will look=
 into the side effects. currently i don't know, what happens, because t=
hey shouldn't be rejected if the pressure is greater than zero and ther=
efore it should take the old codepath.

- Adam


On September 29th, 2010, 3:35 p.m., Adam wrote:

Review request for KOffice.
By Adam.

Updated 2010-09-29 15:35:42

Descripti= on 

QTabletEvent has no information about which button was press=
ed on the stylus. We have to reject it, so that it gets resent as a QMouseE=
vent with the correct buttons.

Testing <= /h1> 
panning and popup palette in krita works now.

Diffs=

  • /trunk/koffice/libs/flake/KoToolProxy.cpp = (1180634)

View Diff
--===============4137881751906459231==-- --===============1304890080== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1304890080==--