This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5441/

The name c=
hange makes sense (though I didn't ensure the code does what you said, =
I'm taking your word  :-)  ).
Just remember to update the Apidoc as I suggest below.

= = = = = =

/trunk/koffice/kr= ita/image/kis_painter.h (Diff revision 1)
public:
307	* update, but you can = call dirtyRegion() to get the region that needs to be notified by your	307	* update, but you can = call dirtyRegion() to get the region that needs to be notified by your
308	* painting code.	308	* painting code.
309	*	309	*
310	* Call will RESET the = dirtyRegion!	310	* Call will RESET the = dirtyRegion!
311	*/	311	*/
312	QRegion dirtyRegion();<= /span>	312	QRegion takeDirtyRegion= ();
313		313

Please update this apidoc to better describe what the function does,=
 and to use the name takeDirtyRegion() too.

- Pentalis

On September 24th, 2010, 6:05 p.m., Adam C. wrote:

Review request for KOffice.

By Adam C..

Updated 2010-09-24 18:05:09

Descripti= on

the name dirtRegion is misleading, as it doesn't imply, =
that the region gets erased in the same method.

Diffs=

/trunk/koffice/krita/benchmarks/kis_floodfill_benchmark.cpp (1179150)
/trunk/koffice/krita/benchmarks/kis_gradient_benchmark.cpp (1179150)
/trunk/koffice/krita/image/kis_painter.h (= 1179150)
/trunk/koffice/krita/image/kis_painter.cc = (1179150)
/trunk/koffice/krita/image/recorder/kis_recorded_paint_action.cpp (1179150)
/trunk/koffice/krita/image/tests/kis_projection_test.cpp (1179150)
/trunk/koffice/krita/plugins/extensions/painterlyframework/mixertool.c= pp (1179150)
/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_brush.cc (1179150)
/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_ellipse.cc (1179150)
/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.cc (1179150)
/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_line.cc (1179150)
/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_path.cc (1179150)
/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_rectangle.cc = (1179150)
/trunk/koffice/krita/plugins/tools/tool_dyna/kis_tool_dyna.cpp (1179150)
/trunk/koffice/krita/plugins/tools/tool_polygon/kis_tool_polygon.cc (1179150)
/trunk/koffice/krita/plugins/tools/tool_polyline/kis_tool_polyline.cc = (1179150)
/trunk/koffice/krita/plugins/tools/tool_star/kis_tool_star.cc (1179150)
/trunk/koffice/krita/ui/tool/kis_tool_freehand_p.cpp (1179150)
/trunk/koffice/krita/ui/widgets/kis_scratch_pad.cpp (1179150)

View Diff