[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Internet enabled multi language virtual keyboard.
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-08-30 15:48:20
Message-ID: 20100830154820.28563.8365 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5173/#review7293
-----------------------------------------------------------
/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp
<http://reviewboard.kde.org/r/5173/#comment7389>
QDir::home() may be more suitable
/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp
<http://reviewboard.kde.org/r/5173/#comment7390>
ditto
/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp
<http://reviewboard.kde.org/r/5173/#comment7391>
gainroot?
=
I don't think we can do that in here, thats a security risk. We should =
not have software that runs as root in KOffice svn without a very good reas=
on.
- Thomas
On 2010-08-30 11:01:55, kaushik pendurthi wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5173/
> -----------------------------------------------------------
> =
> (Updated 2010-08-30 11:01:55)
> =
> =
> Review request for KOffice and Mani Chandrasekar.
> =
> =
> Summary
> -------
> =
> This commit adds new features like dynamic addition and removal of langu=
ages to the existing virtual KeyBoard.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/tools/f-office/CMakeLists.txt 1169070 =
> /trunk/koffice/tools/f-office/VirtualKeyBoard.h 1169070 =
> /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp 1169070 =
> /trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.h PRE-C=
REATION =
> /trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.cpp PRE=
-CREATION =
> =
> Diff: http://reviewboard.kde.org/r/5173/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> kaushik
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5173/">http://reviewboard.kde.org/r/5173/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5173/diff/2/?file=34857#file34857line49" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">49</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QDir</span> <span class="n">directory</span> <span class="o">=</span> <span \
class="n">QDir</span><span class="p">(</span><span \
class="s">"/home/user"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QDir::home() may be more suitable</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5173/diff/2/?file=34857#file34857line65" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">65</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">directory</span><span class="p">.</span><span class="n">cd</span><span \
class="p">(</span><span class="s">"/home/user"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ditto</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5173/diff/2/?file=34857#file34857line75" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">changePermissions</span><span \
class="p">(</span><span class="s">"sudo gainroot"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">gainroot?
I don't think we can do that in here, thats a security risk. We should not have \
software that runs as root in KOffice svn without a very good reason.</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On August 30th, 2010, 11:01 a.m., kaushik pendurthi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice and Mani Chandrasekar.</div>
<div>By kaushik pendurthi.</div>
<p style="color: grey;"><i>Updated 2010-08-30 11:01:55</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This commit adds new features like dynamic addition and removal of \
languages to the existing virtual KeyBoard.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/tools/f-office/CMakeLists.txt <span style="color: \
grey">(1169070)</span></li>
<li>/trunk/koffice/tools/f-office/VirtualKeyBoard.h <span style="color: \
grey">(1169070)</span></li>
<li>/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp <span style="color: \
grey">(1169070)</span></li>
<li>/trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5173/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic