--===============1313019269== Content-Type: multipart/alternative; boundary="===============2849483873608735507==" --===============2849483873608735507== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5173/#review7293 ----------------------------------------------------------- /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp QDir::home() may be more suitable /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp ditto /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp gainroot? = I don't think we can do that in here, thats a security risk. We should = not have software that runs as root in KOffice svn without a very good reas= on. - Thomas On 2010-08-30 11:01:55, kaushik pendurthi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5173/ > ----------------------------------------------------------- > = > (Updated 2010-08-30 11:01:55) > = > = > Review request for KOffice and Mani Chandrasekar. > = > = > Summary > ------- > = > This commit adds new features like dynamic addition and removal of langu= ages to the existing virtual KeyBoard. > = > = > Diffs > ----- > = > /trunk/koffice/tools/f-office/CMakeLists.txt 1169070 = > /trunk/koffice/tools/f-office/VirtualKeyBoard.h 1169070 = > /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp 1169070 = > /trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.h PRE-C= REATION = > /trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.cpp PRE= -CREATION = > = > Diff: http://reviewboard.kde.org/r/5173/diff > = > = > Testing > ------- > = > = > Thanks, > = > kaushik > = > --===============2849483873608735507== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5173/

= =

/trunk/koffice/too= ls/f-office/VirtualKeyBoard.cpp (Diff revision 2)

		49	QDir directory =3D QDir= ("/home/user");

QDir::home() may be more suitable

= =

/trunk/koffice/too= ls/f-office/VirtualKeyBoard.cpp (Diff revision 2)

		65	directory.cd("/home/user");

ditto

= =

/trunk/koffice/too= ls/f-office/VirtualKeyBoard.cpp (Diff revision 2)

		75	QString changePermissions("sudo gainroot");

gainroot?

I don't think we can do that in here, thats a security risk. We should =
not have software that runs as root in KOffice svn without a very good reas=
on.

- Thomas

On August 30th, 2010, 11:01 a.m., kaushik pendurthi wrote:

Review request for KOffice and Mani Chandrasekar.

By kaushik pendurthi.

Updated 2010-08-30 11:01:55

Descripti= on

This commit adds new features like  dynamic addition and rem=
oval of languages to the existing virtual KeyBoard.

Diffs=

/trunk/koffice/tools/f-office/CMakeLists.txt (1169070)
/trunk/koffice/tools/f-office/VirtualKeyBoard.h (1169070)
/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp (1169070)
/trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.h (PRE-CREATION)
/trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.cpp (PRE-CREATION)

--===============2849483873608735507==-- --===============1313019269== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1313019269==--