This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5173/

/trunk/koffice/tools/f-office/VirtualKeyBoard.cpp (Diff revision 2) 


  

 




 
 



 

  

    
    

    49
    
    QDir directory = QDir("/home/user");

  


 





QDir::home() may be more suitable














 
  

   
    /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   


  

 




 
 



 

  

    
    

    65
    
    directory.cd("/home/user");

  


 





ditto














 
  

   
    /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   


  

 




 
 



 

  

    
    

    75
    
        QString changePermissions("sudo gainroot");

  


 





gainroot?

I don't think we can do that in here, thats a security risk. We should not have software that runs as root in KOffice svn without a very good reason.









- Thomas






On August 30th, 2010, 11:01 a.m., kaushik pendurthi wrote:









 

  


Review request for KOffice and Mani Chandrasekar.


By kaushik pendurthi.




Updated 2010-08-30 11:01:55






Description 



 

  
   
This commit adds new features like  dynamic addition and removal of languages to the existing virtual KeyBoard.

  		
 









Diffs 


    

 
  • /trunk/koffice/tools/f-office/CMakeLists.txt (1169070)
    • 

 
  • /trunk/koffice/tools/f-office/VirtualKeyBoard.h (1169070)
    • 

 
  • /trunk/koffice/tools/f-office/VirtualKeyBoard.cpp (1169070)
    • 

 
  • /trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.h (PRE-CREATION)
    • 

 
  • /trunk/koffice/tools/f-office/VirtualKeyBoardLanguageDownloader.cpp (PRE-CREATION)
    • 





View Diff