[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Removes harcoded paths for saving files.
From: "Mani Chandrasekar" <maninc () gmail ! com>
Date: 2010-08-26 10:19:22
Message-ID: 20100826101922.8786.97272 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5154/#review7223
-----------------------------------------------------------
Ship it!
- Mani
On 2010-08-26 10:06:42, Kaushal M wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5154/
> -----------------------------------------------------------
> =
> (Updated 2010-08-26 10:06:42)
> =
> =
> Review request for KOffice and Mani Chandrasekar.
> =
> =
> Summary
> -------
> =
> This patch removes hardcoded paths that were used. They have been replace=
d using QDesktopServices::getStorageLoactaion().
> =
> Also changed the name of the function to make it more descriptive of the =
actual function it performs.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/tools/f-office/MainWindow.h 1168266 =
> trunk/koffice/tools/f-office/MainWindow.cpp 1168266 =
> =
> Diff: http://reviewboard.kde.org/r/5154/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Kaushal
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5154/">http://reviewboard.kde.org/r/5154/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Mani</p>
<br />
<p>On August 26th, 2010, 10:06 a.m., Kaushal M wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice and Mani Chandrasekar.</div>
<div>By Kaushal M.</div>
<p style="color: grey;"><i>Updated 2010-08-26 10:06:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch removes hardcoded paths that were used. They have been \
replaced using QDesktopServices::getStorageLoactaion().
Also changed the name of the function to make it more descriptive of the actual \
function it performs.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/tools/f-office/MainWindow.h <span style="color: \
grey">(1168266)</span></li>
<li>trunk/koffice/tools/f-office/MainWindow.cpp <span style="color: \
grey">(1168266)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5154/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic