From koffice-devel Thu Aug 26 10:19:22 2010 From: "Mani Chandrasekar" Date: Thu, 26 Aug 2010 10:19:22 +0000 To: koffice-devel Subject: Re: Review Request: Removes harcoded paths for saving files. Message-Id: <20100826101922.8786.97272 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128281803728447 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0205217524==" --===============0205217524== Content-Type: multipart/alternative; boundary="===============1007140954416629929==" --===============1007140954416629929== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5154/#review7223 ----------------------------------------------------------- Ship it! - Mani On 2010-08-26 10:06:42, Kaushal M wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5154/ > ----------------------------------------------------------- > = > (Updated 2010-08-26 10:06:42) > = > = > Review request for KOffice and Mani Chandrasekar. > = > = > Summary > ------- > = > This patch removes hardcoded paths that were used. They have been replace= d using QDesktopServices::getStorageLoactaion(). > = > Also changed the name of the function to make it more descriptive of the = actual function it performs. > = > = > Diffs > ----- > = > trunk/koffice/tools/f-office/MainWindow.h 1168266 = > trunk/koffice/tools/f-office/MainWindow.cpp 1168266 = > = > Diff: http://reviewboard.kde.org/r/5154/diff > = > = > Testing > ------- > = > = > Thanks, > = > Kaushal > = > --===============1007140954416629929== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5154/

Ship it!

- Mani


On August 26th, 2010, 10:06 a.m., Kaushal M wrote:

Review request for KOffice and Mani Chandrasekar.
By Kaushal M.

Updated 2010-08-26 10:06:42

Descripti= on 

This patch removes hardcoded paths that were used. They have=
 been replaced using QDesktopServices::getStorageLoactaion().

Also changed the name of the function to make it more descriptive of the ac=
tual function it performs.

Diffs=

  • trunk/koffice/tools/f-office/MainWindow.h = (1168266)
  • trunk/koffice/tools/f-office/MainWindow.cpp View Diff
--===============1007140954416629929==-- --===============0205217524== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0205217524==--