'Re: Review Request: make kogenstyle's addProperty add properties by'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: make kogenstyle's addProperty add properties by
From:       jos.van.den.oever () kogmbh ! com
Date:       2010-08-25 8:27:30
Message-ID: 20100825082730.3805.93493 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5136/#review7208
-----------------------------------------------------------

Ship it!

This is a welcome patch. The mapping of auto styles and normal styles to a =
common identifier is good.
You can now also remove DefaultType from s_propertyTypes and s_propertyName=
s.
It would be best to totally remove DefaultType from the public interface an=
d do manual overloading for methods where the DefaultType was a default arg=
ument value, but this patch is good as it is.

- vandenoever

On 2010-08-25 07:39:09, Lassi Nieminen wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5136/
> -----------------------------------------------------------
> =

> (Updated 2010-08-25 07:39:09)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Makes KoGenStyle's addProperty functions add the properties by default as=
 the native type of the style if possible.
> This fixes e.g. the case where someone does addProperty("x", "y") and the=
n tries to write this property with
> writeStyleProperties.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/odf/KoGenStyle.h 1167637 =

>   trunk/koffice/libs/odf/KoGenStyle.cpp 1167637 =

> =

> Diff: http://reviewboard.kde.org/r/5136/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Lassi
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5136/">http://reviewboard.kde.org/r/5136/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a welcome patch. \
The mapping of auto styles and normal styles to a common identifier is good. You can \
now also remove DefaultType from s_propertyTypes and s_propertyNames. It would be \
best to totally remove DefaultType from the public interface and do manual \
overloading for methods where the DefaultType was a default argument value, but this \
patch is good as it is.</pre>  <br />

<p>- vandenoever</p>

<br />
<p>On August 25th, 2010, 7:39 a.m., Lassi Nieminen wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Lassi Nieminen.</div>

<p style="color: grey;"><i>Updated 2010-08-25 07:39:09</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Makes KoGenStyle&#39;s addProperty functions add the properties by \
default as the native type of the style if possible. This fixes e.g. the case where \
someone does addProperty(&quot;x&quot;, &quot;y&quot;) and then tries to write this \
property with writeStyleProperties.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/odf/KoGenStyle.h <span style="color: \
grey">(1167637)</span></li>

 <li>trunk/koffice/libs/odf/KoGenStyle.cpp <span style="color: \
grey">(1167637)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5136/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 