This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5136/

Ship it!

This is a welcome patch. The mapping of auto styles and normal styles to a common identifier is good.
You can now also remove DefaultType from s_propertyTypes and s_propertyNames.
It would be best to totally remove DefaultType from the public interface and do manual overloading for methods where the DefaultType was a default argument value, but this patch is good as it is.

- vandenoever


On August 25th, 2010, 7:39 a.m., Lassi Nieminen wrote:

Review request for KOffice.
By Lassi Nieminen.

Updated 2010-08-25 07:39:09

Description

Makes KoGenStyle's addProperty functions add the properties by default as the native type of the style if possible.
This fixes e.g. the case where someone does addProperty("x", "y") and then tries to write this property with
writeStyleProperties.

Diffs

  • trunk/koffice/libs/odf/KoGenStyle.h (1167637)
  • trunk/koffice/libs/odf/KoGenStyle.cpp (1167637)

View Diff