--===============1259029135== Content-Type: multipart/alternative; boundary="===============1383360879810884232==" --===============1383360879810884232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5136/#review7208 ----------------------------------------------------------- Ship it! This is a welcome patch. The mapping of auto styles and normal styles to a = common identifier is good. You can now also remove DefaultType from s_propertyTypes and s_propertyName= s. It would be best to totally remove DefaultType from the public interface an= d do manual overloading for methods where the DefaultType was a default arg= ument value, but this patch is good as it is. - vandenoever On 2010-08-25 07:39:09, Lassi Nieminen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5136/ > ----------------------------------------------------------- > = > (Updated 2010-08-25 07:39:09) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Makes KoGenStyle's addProperty functions add the properties by default as= the native type of the style if possible. > This fixes e.g. the case where someone does addProperty("x", "y") and the= n tries to write this property with > writeStyleProperties. > = > = > Diffs > ----- > = > trunk/koffice/libs/odf/KoGenStyle.h 1167637 = > trunk/koffice/libs/odf/KoGenStyle.cpp 1167637 = > = > Diff: http://reviewboard.kde.org/r/5136/diff > = > = > Testing > ------- > = > = > Thanks, > = > Lassi > = > --===============1383360879810884232== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5136/

Ship it!

This is a =
welcome patch. The mapping of auto styles and normal styles to a common ide=
ntifier is good.
You can now also remove DefaultType from s_propertyTypes and s_propertyName=
s.
It would be best to totally remove DefaultType from the public interface an=
d do manual overloading for methods where the DefaultType was a default arg=
ument value, but this patch is good as it is.

- vandenoever

On August 25th, 2010, 7:39 a.m., Lassi Nieminen wrote:

Review request for KOffice.

By Lassi Nieminen.

Updated 2010-08-25 07:39:09

Descripti= on

Makes KoGenStyle's addProperty functions add the propert=
ies by default as the native type of the style if possible.
This fixes e.g. the case where someone does addProperty("x", &quo=
t;y") and then tries to write this property with
writeStyleProperties.

Diffs=

trunk/koffice/libs/odf/KoGenStyle.h (11676= 37)
trunk/koffice/libs/odf/KoGenStyle.cpp (116= 7637)

--===============1383360879810884232==-- --===============1259029135== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1259029135==--