[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Add loading/saving support for user-defined
From: "Robert Marmorstein" <robert () narnia ! homeunix ! com>
Date: 2010-08-24 6:33:57
Message-ID: 20100824063357.32401.67076 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5092/
-----------------------------------------------------------
(Updated 2010-08-24 06:33:56.883186)
Review request for KOffice and Thomas Zander.
Changes
-------
This addresses the things Thomas caught, including the unit test crash.
Summary
-------
While koffice supports loading and saving of DateVariable and other Variabl=
es defined by plugins, support for user-defined variables (in KoNamedVariab=
le) was missing. This patch adds support for user-defined variables using =
the "user-field-decls" tag from the ODF spec, sections 6.3.5-6.3.7. Becaus=
e KoNamedVariables are not created by a factory class, the code for loading=
had to be directly embedded into the KoTextLoader, so there is an empty "l=
oadOdf" function in KoNamedVariable.cpp (it can't go away entirely, because=
inheriting classes need it).
Variables defined as plugins are not affected by these changes, but it look=
s to me like they are not correctly implemented -- they should save to the =
ODF file as "simple variables", not simply as embedded text. =
Note: This patch doesn't add any UI functionality for manipulating variable=
s. It is still needed to have a way for the user to directly add, delete, =
and edit variables. =
Diffs (updated)
-----
trunk/koffice/libs/kotext/KoNamedVariable.cpp 1167249 =
trunk/koffice/libs/kotext/KoTextShapeData.cpp 1167249 =
trunk/koffice/libs/kotext/opendocument/KoTextLoader.h 1167249 =
trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1167249 =
Diff: http://reviewboard.kde.org/r/5092/diff
Testing
-------
Created a document, embedded some user-defined variables in it (by way of t=
he publish-to docker), saved it. Closed out and opened it first in OpenOff=
ice (which works fine) and then in kword again (which also works fine). Va=
riables are saved and displayed just fine.
Thanks,
Robert
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5092/">http://reviewboard.kde.org/r/5092/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice and Thomas Zander.</div>
<div>By Robert Marmorstein.</div>
<p style="color: grey;"><i>Updated 2010-08-24 06:33:56.883186</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This addresses the things Thomas caught, including the unit test \
crash.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While koffice supports loading and saving of DateVariable and other \
Variables defined by plugins, support for user-defined variables (in KoNamedVariable) \
was missing. This patch adds support for user-defined variables using the \
"user-field-decls" tag from the ODF spec, sections 6.3.5-6.3.7. Because \
KoNamedVariables are not created by a factory class, the code for loading had to be \
directly embedded into the KoTextLoader, so there is an empty "loadOdf" \
function in KoNamedVariable.cpp (it can't go away entirely, because inheriting \
classes need it).
Variables defined as plugins are not affected by these changes, but it looks to me \
like they are not correctly implemented -- they should save to the ODF file as \
"simple variables", not simply as embedded text.
Note: This patch doesn't add any UI functionality for manipulating variables. It \
is still needed to have a way for the user to directly add, delete, and edit \
variables. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created a document, embedded some user-defined variables in it (by way \
of the publish-to docker), saved it. Closed out and opened it first in OpenOffice \
(which works fine) and then in kword again (which also works fine). Variables are \
saved and displayed just fine.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/kotext/KoNamedVariable.cpp <span style="color: \
grey">(1167249)</span></li>
<li>trunk/koffice/libs/kotext/KoTextShapeData.cpp <span style="color: \
grey">(1167249)</span></li>
<li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.h <span style="color: \
grey">(1167249)</span></li>
<li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1167249)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5092/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic