This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5092/

Review request for KOffice and Thomas Zander.

By Robert Marmorstein.

Updated 2010-08-24 06:33:56.883186

Changes

This addresses the things Thomas caught, including the unit =
test crash.

Descripti= on

While koffice supports loading and saving of DateVariable an=
d other Variables defined by plugins, support for user-defined variables (i=
n KoNamedVariable) was missing.  This patch adds support for user-defined v=
ariables using the "user-field-decls" tag from the ODF spec, sect=
ions 6.3.5-6.3.7.  Because KoNamedVariables are not created by a factory cl=
ass, the code for loading had to be directly embedded into the KoTextLoader=
, so there is an empty "loadOdf" function in KoNamedVariable.cpp =
(it can't go away entirely, because inheriting classes need it).

Variables defined as plugins are not affected by these changes, but it look=
s to me like they are not correctly implemented -- they should save to the =
ODF file as "simple variables", not simply as embedded text.  =


Note: This patch doesn't add any UI functionality for manipulating vari=
ables.  It is still needed to have a way for the user to directly add, dele=
te, and edit variables.

Testing <= /h1>

Created a document, embedded some user-defined variables in =
it (by way of the publish-to docker), saved it.  Closed out and opened it f=
irst in OpenOffice (which works fine) and then in kword again (which also w=
orks fine).  Variables are saved and displayed just fine.

Diffs= (updated)

trunk/koffice/libs/kotext/KoNamedVariable.cpp (1167249)
trunk/koffice/libs/kotext/KoTextShapeData.cpp (1167249)
trunk/koffice/libs/kotext/opendocument/KoTextLoader.h (1167249)
trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp (1167249)

View Diff

Changes This addresses the things Thomas caught, including the unit = test crash.

Descripti= on

Testing <= /h1> Created a document, embedded some user-defined variables in = it (by way of the publish-to docker), saved it. Closed out and opened it f= irst in OpenOffice (which works fine) and then in kword again (which also w= orks fine). Variables are saved and displayed just fine.

Diffs= (updated)

Changes

This addresses the things Thomas caught, including the unit = test crash.

Testing <= /h1>

Created a document, embedded some user-defined variables in = it (by way of the publish-to docker), saved it. Closed out and opened it f= irst in OpenOffice (which works fine) and then in kword again (which also w= orks fine). Variables are saved and displayed just fine.