[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: add filnameOfStore() to KoStore
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-01-24 16:50:38
Message-ID: 20100124165038.21055.31929 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2642/
-----------------------------------------------------------

(Updated 2010-01-24 16:50:37.879813)


Review request for KOffice.


Changes
-------

ok another change as requested.

have not done the extra arg to the KoStorePrivate though


Summary
-------

Added a filenameOfStore() method and some code to make it work

When loading ODF sometimes there is a href to a file relative to the store, so it's \
important that the loading code can find out what the url of the store is in order to \
resolve the relation.


Diffs (updated)
-----

  trunk/koffice/libs/store/CMakeLists.txt 1079527 
  trunk/koffice/libs/store/KoDirectoryStore.h 1079527 
  trunk/koffice/libs/store/KoEncryptedStore.h 1079527 
  trunk/koffice/libs/store/KoEncryptedStore.cpp 1079527 
  trunk/koffice/libs/store/KoStore.h 1079527 
  trunk/koffice/libs/store/KoStore.cpp 1079527 
  trunk/koffice/libs/store/KoStoreBase.h 1079527 
  trunk/koffice/libs/store/KoStoreBase.cpp 1079527 
  trunk/koffice/libs/store/KoStore_p.h PRE-CREATION 
  trunk/koffice/libs/store/KoTarStore.h 1079527 
  trunk/koffice/libs/store/KoTarStore.cpp 1079527 
  trunk/koffice/libs/store/KoZipStore.h 1079527 
  trunk/koffice/libs/store/KoZipStore.cpp 1079527 

Diff: http://reviewboard.kde.org/r/2642/diff


Testing
-------

I'm using it loacaly in my videoshape and it works.
Not all means of creating a store will currently result in a valid url returned from \
filenameOfStore() but this is hinted at in the documentation.


Thanks,

Casper

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]