[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: add filnameOfStore() to KoStore
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-01-24 15:35:27
Message-ID: 20100124153527.19193.20971 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2642/#review3843
-----------------------------------------------------------


Adding setters/getters for all the private members doesn't sound like it helps much \
with speed or maintainability. I was thinking that you instead share the private \
object between all the store implementations so you can still use the private object \
from a subclass. See KoShape and KoShapeContainer for an example. The D_D macros etc.
So, please remove all those public methods on KoStore again, they are not needed in \
the public API.


trunk/koffice/libs/store/KoStore.h
<http://reviewboard.kde.org/r/2642/#comment3229>

    you forgot to adjust your editor for all those trailing spaces...



trunk/koffice/libs/store/KoTarStore.cpp
<http://reviewboard.kde.org/r/2642/#comment3230>

    Instead of duplicating the call to the setter in each of the subclasses I think \
you want to just make the KoStorePrivate constructor take it as an argument so you \
only have to do it once. MUch more maintainable.


- Thomas


On 2010-01-24 14:34:12, Casper Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 14:34:12)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added a filenameOfStore() method and some code to make it work
> 
> When loading ODF sometimes there is a href to a file relative to the store, so it's \
> important that the loading code can find out what the url of the store is in order \
> to resolve the relation. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/store/CMakeLists.txt 1079527 
> trunk/koffice/libs/store/KoDirectoryStore.h 1079527 
> trunk/koffice/libs/store/KoEncryptedStore.h 1079527 
> trunk/koffice/libs/store/KoEncryptedStore.cpp 1079527 
> trunk/koffice/libs/store/KoStore.h 1079527 
> trunk/koffice/libs/store/KoStore.cpp 1079527 
> trunk/koffice/libs/store/KoStoreBase.h 1079527 
> trunk/koffice/libs/store/KoStoreBase.cpp 1079527 
> trunk/koffice/libs/store/KoTarStore.h 1079527 
> trunk/koffice/libs/store/KoTarStore.cpp 1079527 
> trunk/koffice/libs/store/KoZipStore.h 1079527 
> trunk/koffice/libs/store/KoZipStore.cpp 1079527 
> 
> Diff: http://reviewboard.kde.org/r/2642/diff
> 
> 
> Testing
> -------
> 
> I'm using it loacaly in my videoshape and it works.
> Not all means of creating a store will currently result in a valid url returned \
> from filenameOfStore() but this is hinted at in the documentation. 
> 
> Thanks,
> 
> Casper
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]