[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: add filnameOfStore() to KoStore
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-01-24 17:14:11
Message-ID: 20100124171411.21745.71914 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2642/#review3846
-----------------------------------------------------------



trunk/koffice/libs/store/KoStore.h
<http://reviewboard.kde.org/r/2642/#comment3233>

    as a protected method you want to create a constructor that takes a private \
reference; see KoShape::KoShape(KoShapePrivate &)



trunk/koffice/libs/store/KoStore.h
<http://reviewboard.kde.org/r/2642/#comment3231>

    this should be in the private part



trunk/koffice/libs/store/KoStore.cpp
<http://reviewboard.kde.org/r/2642/#comment3232>

    delete the d ptr too to avoid leaking mem



trunk/koffice/libs/store/KoStore_p.h
<http://reviewboard.kde.org/r/2642/#comment3234>

    this won't compile on windows; make it a 'class', not a struct.



trunk/koffice/libs/store/KoStore_p.h
<http://reviewboard.kde.org/r/2642/#comment3235>

    still trailing spaces...



trunk/koffice/libs/store/KoTarStore.cpp
<http://reviewboard.kde.org/r/2642/#comment3236>

    you want to create a KoTarStorePrivate class (in the cpp file is fine) and use \
that in this class by calling the KoStore constructor with the KoStorePrivate \
argument.. See the constructors in KoShapeContainer, for instance.



trunk/koffice/libs/store/KoZipStore.cpp
<http://reviewboard.kde.org/r/2642/#comment3237>

    same argument as kotarstore; create a KoZipPrivate for the members of this class.


- Thomas


On 2010-01-24 16:50:37, Casper Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 16:50:37)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added a filenameOfStore() method and some code to make it work
> 
> When loading ODF sometimes there is a href to a file relative to the store, so it's \
> important that the loading code can find out what the url of the store is in order \
> to resolve the relation. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/store/CMakeLists.txt 1079527 
> trunk/koffice/libs/store/KoDirectoryStore.h 1079527 
> trunk/koffice/libs/store/KoEncryptedStore.h 1079527 
> trunk/koffice/libs/store/KoEncryptedStore.cpp 1079527 
> trunk/koffice/libs/store/KoStore.h 1079527 
> trunk/koffice/libs/store/KoStore.cpp 1079527 
> trunk/koffice/libs/store/KoStoreBase.h 1079527 
> trunk/koffice/libs/store/KoStoreBase.cpp 1079527 
> trunk/koffice/libs/store/KoStore_p.h PRE-CREATION 
> trunk/koffice/libs/store/KoTarStore.h 1079527 
> trunk/koffice/libs/store/KoTarStore.cpp 1079527 
> trunk/koffice/libs/store/KoZipStore.h 1079527 
> trunk/koffice/libs/store/KoZipStore.cpp 1079527 
> 
> Diff: http://reviewboard.kde.org/r/2642/diff
> 
> 
> Testing
> -------
> 
> I'm using it loacaly in my videoshape and it works.
> Not all means of creating a store will currently result in a valid url returned \
> from filenameOfStore() but this is hinted at in the documentation. 
> 
> Thanks,
> 
> Casper
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]