[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kpresentation : Filter added support for header
From:       jos.van.den.oever () kogmbh ! com
Date:       2010-01-11 7:50:32
Message-ID: 20100111075032.10018.52384 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2484/#review3647
-----------------------------------------------------------


Please make sure that the patch not only shows footers and dates when they are needed \
but also that it does not show them when they are not needed.

I would very much appreciate if you added a positive and negative test to the koffice \
tests using the simple test framework I mailed about last week. You could add for \
                example one file with three slides
 - slide 1: no footer, no date
 - slide 2: footer, no date
 - slide 3: footer, date

I can help you with making the tests if you encounter problems, just mail questions \
to the mailing list so the answers are archived too.


- vandenoever


On 2010-01-10 15:57:44, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2484/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 15:57:44)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> 1) Created styles for corresponding header footer. 
> 2) Read headerfooter atom and got the text.
> 3) Insert the text in content.xml decl portion of office:body
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kpresenter/powerpoint/import/datetimeformat.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.cpp 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1072636 
> 
> Diff: http://reviewboard.kde.org/r/2484/diff
> 
> 
> Testing
> -------
> 
> Tested on different ppt files
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]