[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kpresentation : Filter added support for header
From:       "Amit Aggarwal" <amitcs06 () gmail ! com>
Date:       2010-01-11 10:40:22
Message-ID: 20100111104022.14126.77722 () localhost
[Download RAW message or body]



> On 2010-01-11 07:48:14, vandenoever wrote:
> > Please make sure that the patch not only shows footers and dates when they are \
> > needed but also that it does not show them when they are not needed. 
> > I would very much appreciate if you added a positive and negative test to the \
> > koffice tests using the simple test framework I mailed about last week. You could \
> >                 add for example one file with three slides
> > - slide 1: no footer, no date
> > - slide 2: footer, no date
> > - slide 3: footer, date
> > 
> > I can

Yes It will not footer and date when it is not needed. Bcoz in content.xml there is \
style attribute display-footer-name:- true or false.By which we can control the \
display. 

Sure once i will get time i will add the +ve -ve tests.


> On 2010-01-11 07:48:14, vandenoever wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 292
> > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line292>
> > 
> > Why are you using hard-coded numbers here? Please add an explanation comment.

I saw in spec and no where I am able to find the frame size for footer . Let me knw \
how can i get it.


> On 2010-01-11 07:48:14, vandenoever wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 301
> > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line301>
> > 
> > Same point, please explain the hard-coded numbers.
> > 

This is the same as I havent seen any cordinate related info in headerfooterAtom. 


> On 2010-01-11 07:48:14, vandenoever wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 1785
> > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line1785>
> > 
> > Do not print to std::cout or std::err in the normal codepath. Use kDebug() if you \
> > need debug output.

Ok Next time I will take care.As I saw already std::cout is using so I used the same. \
We will take this as action item where we will replace all std::cout with kDebug. 


> On 2010-01-11 07:48:14, vandenoever wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.cpp, line 257
> > <http://reviewboard.kde.org/r/2484/diff/3/?file=16787#file16787line257>
> > 
> > leftover space

Ok Will delete it. 


> On 2010-01-11 07:48:14, vandenoever wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 1799
> > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line1799>
> > 
> > You left a std::cout.

Will delete it.


> On 2010-01-11 07:48:14, vandenoever wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 1802
> > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line1802>
> > 
> > And another std::cout.

Will delete it or put in #ifdef


- Amit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2484/#review3646
-----------------------------------------------------------


On 2010-01-10 15:57:44, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2484/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 15:57:44)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> 1) Created styles for corresponding header footer. 
> 2) Read headerfooter atom and got the text.
> 3) Insert the text in content.xml decl portion of office:body
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kpresenter/powerpoint/import/datetimeformat.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.cpp 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1072636 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1072636 
> 
> Diff: http://reviewboard.kde.org/r/2484/diff
> 
> 
> Testing
> -------
> 
> Tested on different ppt files
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]