[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake
From:       Thomas Zander <zander () kde ! org>
Date:       2009-12-18 9:05:58
Message-ID: 200912181005.59542.zander () kde ! org
[Download RAW message or body]

On Friday 18. December 2009 06.21.18 Thorsten Zachmann wrote:
> On Thursday 17 December 2009 22:38:19 Thomas Zander wrote:
> > The diff size is misleading; when I moved the methods from being on
> > KoPathShapeLoader to being on KoPathShapeLoaderPrivate, I moved them to
> >  the  top of the file so all methods of that class are together.
> > Naturally, the "d->" changes are pretty trivial too, but take a lot of
> >  lines.
> 
> That is not true. You moved the code form the base class KoSvgPathParser
>  and not from the KoPathShapeLoader to the private. The class is very
>  useful for creating a svg parser. But now all lives in one place and can
>  onle be used there.
> I do not see how this is usefull.

Honestly? Really, you don't? Or are you again just fighting to be right?

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]