[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix 2 formatting issues in KWord
From: Mani N C <maninc () gmail ! com>
Date: 2009-12-12 17:44:42
Message-ID: 9445e5350912120932y1d9dd313t524f946ab63dada0 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Attached Test ODT file.
Br,
Mani
On Sat, Dec 12, 2009 at 10:44 PM, Mani Chandrasekar <maninc@gmail.com>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2309/
> -----------------------------------------------------------
>
> (Updated 2009-12-12 17:14:03.202411)
>
>
> Review request for KOffice.
>
>
> Changes
> -------
>
> Attached Screenshot with no top/bottom header size. Will send the odt file
> as well.
> Thomas, you had mentioned about setting the values in CSS file. I point out
> the file which has to be updated? Even if we update there, wont that values
> will be overridden by the default value of KoUnit::parseValue() ?
>
> Have added another fix for displaying endnote. I have sent a patch to
> Casper for fetch endnote from Doc files.
>
> Ran Unit tests and it passed.
>
>
> Summary
> -------
>
> I have two minor changes,
> 1.Set the default margin width to be 20mm. Text starts from top of the page
> with out any margin, If only left & right margin are defined.
>
> 2.Paragraph borders start from the text indent position. Calculating the
> border rect position
>
> I would propose to use KoBorder instead of KoTextBlockBorderData class. As
> this class is reimplementation of KoBorder data. Any comments ?
>
>
> Diffs (updated)
> -----
>
> trunk/koffice/libs/widgets/KoPageLayout.cpp 1054516
> trunk/koffice/plugins/textshape/Layout.cpp 1054516
>
> Diff: http://reviewboard.kde.org/r/2309/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> KWord
> http://reviewboard.kde.org/r/2309/s/277/
> OoWriter
> http://reviewboard.kde.org/r/2309/s/278/
> Abiword converted to PDF using officeshot
> http://reviewboard.kde.org/r/2309/s/279/
>
>
> Thanks,
>
> Mani
>
>
--
N C Manikanda Prasad
[Attachment #5 (text/html)]
Attached Test ODT file.<br><br>Br,<br>Mani<br><br><div class="gmail_quote">On Sat, \
Dec 12, 2009 at 10:44 PM, Mani Chandrasekar <span dir="ltr"><<a \
href="mailto:maninc@gmail.com">maninc@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/2309/" \
target="_blank">http://reviewboard.kde.org/r/2309/</a><br>
-----------------------------------------------------------<br>
<br>
</div>(Updated 2009-12-12 17:14:03.202411)<br>
<br>
<br>
Review request for KOffice.<br>
<br>
<br>
Changes<br>
-------<br>
<br>
Attached Screenshot with no top/bottom header size. Will send the odt file as \
well.<br> Thomas, you had mentioned about setting the values in CSS file. I point out \
the file which has to be updated? Even if we update there, wont that values will be \
overridden by the default value of KoUnit::parseValue() ?<br>
<br>
Have added another fix for displaying endnote. I have sent a patch to Casper for \
fetch endnote from Doc files.<br> <br>
Ran Unit tests and it passed.<br>
<div class="im"><br>
<br>
Summary<br>
-------<br>
<br>
I have two minor changes,<br>
1.Set the default margin width to be 20mm. Text starts from top of the page with out \
any margin, If only left & right margin are defined.<br> <br>
2.Paragraph borders start from the text indent position. Calculating the border rect \
position<br> <br>
I would propose to use KoBorder instead of KoTextBlockBorderData class. As this class \
is reimplementation of KoBorder data. Any comments ?<br> <br>
<br>
</div>Diffs (updated)<br>
<div class="im">-----<br>
<br>
trunk/koffice/libs/widgets/KoPageLayout.cpp 1054516<br>
trunk/koffice/plugins/textshape/Layout.cpp 1054516<br>
<br>
Diff: <a href="http://reviewboard.kde.org/r/2309/diff" \
target="_blank">http://reviewboard.kde.org/r/2309/diff</a><br> <br>
<br>
Testing<br>
-------<br>
<br>
<br>
</div>Screenshots<br>
-----------<br>
<br>
KWord<br>
<a href="http://reviewboard.kde.org/r/2309/s/277/" \
target="_blank">http://reviewboard.kde.org/r/2309/s/277/</a><br> OoWriter<br>
<a href="http://reviewboard.kde.org/r/2309/s/278/" \
target="_blank">http://reviewboard.kde.org/r/2309/s/278/</a><br> Abiword converted to \
PDF using officeshot<br> <a href="http://reviewboard.kde.org/r/2309/s/279/" \
target="_blank">http://reviewboard.kde.org/r/2309/s/279/</a><br> <br>
<br>
Thanks,<br>
<font color="#888888"><br>
Mani<br>
<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>N C Manikanda Prasad<br><br>
--001517740988a60d53047a8b6e47--
["www.icsa.odt" (application/vnd.oasis.opendocument.text)]
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic