[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix 2 formatting issues in KWord
From:       "Mani Chandrasekar" <maninc () gmail ! com>
Date:       2009-12-12 17:14:03
Message-ID: 20091212171403.17812.89559 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2309/
-----------------------------------------------------------

(Updated 2009-12-12 17:14:03.202411)


Review request for KOffice.


Changes
-------

Attached Screenshot with no top/bottom header size. Will send the odt file as well. 
Thomas, you had mentioned about setting the values in CSS file. I point out the file \
which has to be updated? Even if we update there, wont that values will be overridden \
by the default value of KoUnit::parseValue() ?

Have added another fix for displaying endnote. I have sent a patch to Casper for \
fetch endnote from Doc files. 

Ran Unit tests and it passed. 


Summary
-------

I have two minor changes,
1.Set the default margin width to be 20mm. Text starts from top of the page with out \
any margin, If only left & right margin are defined.

2.Paragraph borders start from the text indent position. Calculating the border rect \
position 

I would propose to use KoBorder instead of KoTextBlockBorderData class. As this class \
is reimplementation of KoBorder data. Any comments ? 


Diffs (updated)
-----

  trunk/koffice/libs/widgets/KoPageLayout.cpp 1054516 
  trunk/koffice/plugins/textshape/Layout.cpp 1054516 

Diff: http://reviewboard.kde.org/r/2309/diff


Testing
-------


Screenshots
-----------

KWord
  http://reviewboard.kde.org/r/2309/s/277/
OoWriter
  http://reviewboard.kde.org/r/2309/s/278/
Abiword converted to PDF using officeshot
  http://reviewboard.kde.org/r/2309/s/279/


Thanks,

Mani

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]