[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Patch to load correct version of textual content,
From: jos.van.den.oever () kogmbh ! com
Date: 2009-10-22 12:49:50
Message-ID: 20091022124950.20526.66574 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1919/#review2756
-----------------------------------------------------------
Ship it!
all comments handled nicely
lets get it in before the RC
- vandenoever
On 2009-10-22 08:53:17, Vesa Pikki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1919/
> -----------------------------------------------------------
>
> (Updated 2009-10-22 08:53:17)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This patch fixes font name loading, text bytes and chars loading.
> Powerpoint files contain version history of changes. Currently the oldest version \
> of DocumentContainer is loaded. This patch mofies DocumentContainer loading to use \
> latest version available. This in turn ensures that the latest texts and text \
> styles are loaded.
> This patch renames some related datatypes to match those in powerpoint's definition \
> to make it easier to follow the specification. Some powerpoint data structures \
> were also modified to use QSharedData & QSharedDataPointer.
>
> Diffs
> -----
>
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1038581
> trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.h 1038581
> trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp 1038581
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1038581
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1038581
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.h 1038581
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.cpp 1038581
>
> Diff: http://reviewboard.kde.org/r/1919/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vesa
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic