[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Patch to load correct version of textual content,
From:       "Vesa Pikki" <vesa.pikki () ixonos ! com>
Date:       2009-10-22 8:55:38
Message-ID: 20091022085538.13379.57965 () localhost
[Download RAW message or body]



> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 1383
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13072#file13072line1383>
> > 
> > Instead of using replace, I think you should use QString::remove()

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp, line 246
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13074#file13074line246>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp, line 317
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13074#file13074line317>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp, line 654
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13074#file13074line654>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp, line 696
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13074#file13074line696>
> > 
> > A QString does not have to be initialized. This line does nothing.

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp, line 705
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13074#file13074line705>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 1160
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line1160>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 1171
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line1171>
> > 
> > A QString does not have to be initialized. This just slows things down :)

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 1180
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line1180>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 1270
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line1270>
> > 
> > use name.clear() instead, which is much faster.

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 2893
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line2893>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 3319
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line3319>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 3759
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line3759>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 3782
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line3782>
> > 
> > This constructor should not be needed

fixed


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 5125
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line5125>
> > 
> > unsigned char * ?  Why the 'unsigned' ?

The class is inherited from Record class that has a virtual method setData with also \
unsigned char*. I just followed the original method's way of using unsigned.


> On 2009-10-21 11:08:49, Thomas Zander wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 5206
> > <http://reviewboard.kde.org/r/1919/diff/1/?file=13076#file13076line5206>
> > 
> > that unsigned too is weird here...

see earlier reply.


- Vesa


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1919/#review2738
-----------------------------------------------------------


On 2009-10-22 08:53:17, Vesa Pikki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1919/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 08:53:17)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch fixes font name loading, text bytes and chars loading. 
> Powerpoint files contain version history of changes. Currently the oldest version \
> of DocumentContainer is loaded. This patch mofies DocumentContainer loading to use \
> latest version available. This in turn ensures that the latest texts and text \
> styles are loaded. 
> This patch renames some related datatypes to match those in powerpoint's definition \
> to make it easier to follow the specification.  Some powerpoint data structures \
> were also modified to use QSharedData & QSharedDataPointer. 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1038581 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.h 1038581 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp 1038581 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1038581 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1038581 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.h 1038581 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.cpp 1038581 
> 
> Diff: http://reviewboard.kde.org/r/1919/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vesa
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]