[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add ability to read,
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2009-10-22 14:37:40
Message-ID: 20091022143740.23163.93646 () localhost
[Download RAW message or body]



> On 2009-10-21 07:53:40, Thomas Zander wrote:
> > trunk/koffice/libs/kotext/CMakeLists.txt, line 85
> > <http://reviewboard.kde.org/r/1890/diff/7/?file=13059#file13059line85>
> > 
> > These two changes are not needed.

Fixed


> On 2009-10-21 07:53:40, Thomas Zander wrote:
> > trunk/koffice/libs/odf/KoBorder.h, line 148
> > <http://reviewboard.kde.org/r/1890/diff/7/?file=13064#file13064line148>
> > 
> > Don't use more than one consecutive space

That makes it easier to read, and is not part of the coding standard.


> On 2009-10-21 07:53:40, Thomas Zander wrote:
> > trunk/koffice/libs/odf/KoBorder.cpp, line 687
> > <http://reviewboard.kde.org/r/1890/diff/7/?file=13065#file13065line687>
> > 
> > curly brace is misplaced

I changed it and the code is now more difficult to read.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1890/#review2737
-----------------------------------------------------------


On 2009-10-21 00:47:01, Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1890/
> -----------------------------------------------------------
> 
> (Updated 2009-10-21 00:47:01)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to read, store and save page borders in text documents.
> 
> So far it does not paint the borders, because I couldn't understand the paint code \
> of KWord, but I hope to get some help with that today. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/CMakeLists.txt 1037806 
> trunk/koffice/libs/kotext/KoTextBlockBorderData.cpp 1037806 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1037806 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1037806 
> trunk/koffice/libs/odf/CMakeLists.txt 1037806 
> trunk/koffice/libs/odf/KoBorder.h PRE-CREATION 
> trunk/koffice/libs/odf/KoBorder.cpp PRE-CREATION 
> trunk/koffice/libs/widgets/KoPageLayout.h 1037806 
> trunk/koffice/libs/widgets/KoPageLayout.cpp 1037806 
> trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp 1037806 
> 
> Diff: http://reviewboard.kde.org/r/1890/diff
> 
> 
> Testing
> -------
> 
> I have tested with loading and saving a document that contains page borders created \
> in OOo. 
> 
> Thanks,
> 
> Inge
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]