[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Improve the toolbox layout
From:       jaham () gmx ! net
Date:       2009-07-19 11:23:18
Message-ID: 200907191323.19686.jaham () gmx ! net
[Download RAW message or body]

On Saturday 18 July 2009 11:05:32 Thomas Zander wrote:
> Hey Thorsten :)
>
> First,
>
> These suggestions you replied to are not specific to KPresenter, they are
> meant to extend the concepts of flake and meant to extend in a cross-
> application and consistent way the experience of how to manage tools and
> dockers.
> KPresenter is just used as an example, please don't take any of this
> personally, its not :)
>
> On Saturday 18. July 2009 07.00.04 Thorsten Zachmann wrote:
> > > my memory of the discussion some months ago was that we could fix the
> > > toolbox very easily (2 lines fix) but the ideal is not to fix that but
> > > figure out why the different apps come up with different solutions for
> > > similar problems and ending up, well, working against each other.
> >
> > If it is so easily fixed why are you so resistant in fixing it.
>
> The toolbox as it is now has been written in 2005 for Karbon and (later)
> Krita with a design in mind of sections. In 2008 or so I rewrote it for Qt4
> kept that design and extended it.
> Any 'fix' in the toolbox would either allow a section to be huge or even
> infinitely long. Thats not really a fix as KPresenter will *still* have a
> bad looking toolbox afterwards.
> So, I don't think its fair to say I'm resistant to fixing it, I am not. I
> just want the fix to be in line with what Krita has been doing for years
> (with more tools, so KPresenter should be able to do so too) and what fits
> in the design of the toolbox.
>
> > Only that
> > there is an agreement that a lot of tools should be avoided does not mean
> > the tool box should break when there are more tools. It is very easy for
> > a plugin developer to add new tools. That should not break the existing
> > applications. So lets fix the toolbox.
> >
> > > So,
> > > yes, the current situation is not very useful and needs resolving.
> > > Changing the layout of the toolbox is going in the wrong direction,
> > > though. We would end up with even less coherence in design and less
> > > consistency between apps.
> >
> > Sorry but that sounds like you are against fixing the toolbox.
>
> I'm slightly annoyed you keep insisting we should just remove features from
> the toolbox that I added and you mark it as a 'fix'.
> Can we please stay constructive?

Which feature does the patch remove, exactly?
And more to the point, how do you want to prevent more than 10 tools being in 
the same section once external tool plugins are loaded?

Ciao Jan
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]