[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] KoOdfExporter and MSWordOdfImport port & fixes
From:       Jaroslaw S <kexipl () gmail ! com>
Date:       2009-05-30 22:02:49
Message-ID: 56a746380905301502v3700423bxbe1ca55f21b0cc3a () mail ! gmail ! com
[Download RAW message or body]

2009/5/30  <cricketc@gmail.com>:
> On Friday 29 May 2009 09:50:43 Jarosław Staniek wrote:
>> Dear all,
>> For review:
>>
>> 1. KoOdfExporter.patch
>> The goal: the code in convert is common, so KoOdfExporter is introduced to
>> avoid copy/pastes.
>>
>> *created KoOdfExporter
>> **based on MSWordOdfImport::convert()
>> **added KoOdfWriters helper struct to make the API a bit cleaner
>>
>> 2. MSWordOdfImport.patch
>> *MSWordOdfImport:
>> **MSWordOdfImport is also ported to KoOdfExporter API
>> **fixed warnings in MSWordOdfImport's Document::Document()
>> **removed uses of QConstString
>> **moved filename conversion to Document ctor
>> **Document::processStyles(): fixed bug in 'i' variable used twice
>
> I like the idea of consolidating that code if it's reused a lot, but I'm
> getting some errors in my test documents with your patches.

I guess it's on .doc files? May I have one example?

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & KOffice (http://www.kexi-project.org, http://www.koffice.org)
 KDE Libraries for MS Windows (http://windows.kde.org)
 http://www.linkedin.com/in/jstaniek
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]