[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] KoOdfExporter and MSWordOdfImport port & fixes
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-05-31 4:27:00
Message-ID: 200905310627.00488.t.zachmann () zagge ! de
[Download RAW message or body]

On Friday 29 May 2009, Jarosław Staniek wrote:
> Dear all,
> For review:
>
> 1. KoOdfExporter.patch
> The goal: the code in convert is common, so KoOdfExporter is introduced to
> avoid copy/pastes.
>
> *created KoOdfExporter
> **based on MSWordOdfImport::convert()
> **added KoOdfWriters helper struct to make the API a bit cleaner
>

+    // open main tags
+    bodyWriter.startElement("office:body");
+    bodyWriter.startElement("office:text");

This should be done is the createDocument method, to allow also other type of 
doucments to be created. e.g. a office:presentation.
 
+    //now create real content/body writers & dump the information there
+    KoXmlWriter* realContentWriter = oasisStore.contentWriter();
+    realContentWriter->addCompleteElement(&contentBuf);
+    KoXmlWriter* realBodyWriter = oasisStore.bodyWriter();
+    realBodyWriter->addCompleteElement(&bodyBuf);

Why is this copy needed? Can't you use the correct writers from the beginning?

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]