[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Rename KCurve to KisCurveWidget
From:       "Dmitry Kazakov" <dimula73 () gmail ! com>
Date:       2009-04-27 19:07:42
Message-ID: 20090427190742.27358.74531 () localhost
[Download RAW message or body]



> On None, Sven Langkamp wrote:
> > Looks good to me.

Well, it's strange, but i've not got this review by e-mail =(
I'll recompile it soon and commit.


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/590/#review978
-----------------------------------------------------------


On 2009-04-14 14:27:17, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/590/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 14:27:17)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This is a cosmetic patch. I renamed the class and fixed all its dependencies.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.cc \
> 953946  trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.h \
> 953946  trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.cc \
> 953946  trunk/koffice/krita/plugins/filters/colorsfilters/wdg_brightness_contrast.ui \
> 953946  trunk/koffice/krita/plugins/filters/colorsfilters/wdg_perchannel.ui 953946 
> trunk/koffice/krita/plugins/paintops/complexop/kis_complexop.h 953946 
> trunk/koffice/krita/plugins/paintops/complexop/kis_complexop.cpp 953946 
> trunk/koffice/krita/plugins/paintops/complexop/kis_complexop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/complexop/wdgbrushcurves.ui 953946 
> trunk/koffice/krita/plugins/paintops/defaultpaintops/airbrush/kis_airbrushop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/brush/kis_brushop.h \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/brush/kis_brushop.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.h \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/eraser/kis_eraseop.h \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/eraser/kis_eraseop.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/eraser/kis_eraseop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/pen/kis_penop.h 953946 \
>  trunk/koffice/krita/plugins/paintops/defaultpaintops/pen/kis_penop.cpp 953946 
> trunk/koffice/krita/plugins/paintops/defaultpaintops/pen/kis_penop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/smudge/kis_smudgeop.h \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/smudge/kis_smudgeop.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/defaultpaintops/smudge/kis_smudgeop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/filterop/kis_filterop.cpp 953946 
> trunk/koffice/krita/plugins/paintops/filterop/kis_filterop_settings_widget.cpp \
> 953946  trunk/koffice/krita/plugins/paintops/libpaintop/kis_curve_option.h 953946 
> trunk/koffice/krita/plugins/paintops/libpaintop/kis_curve_option.cpp 953946 
> trunk/koffice/krita/plugins/paintops/libpaintop/kis_pressure_rate_option.cpp 953946 \
>  trunk/koffice/krita/plugins/paintops/sumie/brush.cpp 953946 
> trunk/koffice/krita/plugins/paintops/sumie/wdgsumieoptions.ui 953946 
> trunk/koffice/krita/ui/CMakeLists.txt 953946 
> trunk/koffice/krita/ui/widgets/kcurve.h 953946 
> trunk/koffice/krita/ui/widgets/kcurve.cc 953946 
> trunk/koffice/krita/ui/widgets/kcurve_p.h 953946 
> trunk/koffice/krita/ui/widgets/kis_curve_widget.h 953903 
> trunk/koffice/krita/ui/widgets/kis_curve_widget.cpp 953903 
> trunk/koffice/krita/ui/widgets/kis_curve_widget_p.h 953903 
> 
> Diff: http://reviewboard.kde.org/r/590/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]