[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Krita: Size canvas feature
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2009-04-05 21:20:16
Message-ID: 20090405212016.30259.11437 () localhost
[Download RAW message or body]



> On 2009-03-04 13:19:24, Boudewijn Rempt wrote:
> > This patch will make Boemann very happy! Unfortunately we really have to wait \
> > with committing this for trunk to open for features and strings again.
> 
> antiquark wrote:
> I started working on an update taking some of Langkamp's suggestions into \
> consideration. However I'm VERY busy with other things so it will take some time. \
> Hopefully it will be better by the time trunk is open to new features.

How are we on this ? Trunk is now opened again, should we commit it ? Or wait for the \
improved version ?


- Cyrille


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/220/#review358
-----------------------------------------------------------


On 2009-03-02 10:48:28, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/220/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 10:48:28)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to change the size of the canvas in Krita and set the \
> anchoring point. The patch makes use of KisCropVisitor to perform cropping. 
> The plugin adds some PNG images which are available here -> \
> http://www.2shared.com/file/4988334/236a0051/arrowstar.html.  They should be \
> extracted in /krita/plugins/viewplugins/imagesize/pics 
> 
> Diffs
> -----
> 
> /trunk/koffice/krita/image/kis_image.h 934295 
> /trunk/koffice/krita/image/kis_image.cc 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/CMakeLists.txt 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/dlg_canvassize.h PRE-CREATION 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/dlg_canvassize.cc PRE-CREATION 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/imagesize.h 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/imagesize.cc 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/imagesize.rc 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/CMakeLists.txt PRE-CREATION \
>                 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_east.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_north.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_north_east.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_north_west.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_south.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_south_east.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_south_west.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_west.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/wdg_canvassize.ui PRE-CREATION 
> /trunk/koffice/krita/ui/kis_image_manager.h 934295 
> /trunk/koffice/krita/ui/kis_image_manager.cc 934295 
> 
> Diff: http://reviewboard.kde.org/r/220/diff
> 
> 
> Testing
> -------
> 
> Works fine, except when there are masks. The KisCropVisitor class does not handle \
> cropping of masks and therefore this deficiency is propagated. 
> 
> Screenshots
> -----------
> 
> Size Canvas
> http://reviewboard.kde.org/r/220/s/44/
> 
> 
> Thanks,
> 
> antiquark
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]