[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Filter effects for karbon
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2009-04-05 21:08:53
Message-ID: 20090405210853.30053.3302 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/529/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

This patch is a proof of concepts to add filter effects to karbon (and flake for that \
matter). It's still very early, and for now I would like to have opinion on whether I \
am in the good direction for this. A few comments:
* the patch to flake is just meant to make the plugin not depending on any karbon \
code (not sure if it's useful, or if not giving access to KoShapeControllerBase is \
                done on purpose)
* for some reason, the shape isn't always redisplayed
* currently I abuse the "isClipped" feature of KoShapeContainer, not sure if it was \
                intended to be use like this
* I would like the container to be unselectable, or at least the click to be \
redirected to shape containing the container

So what's your opinion ? Is it a good start, should it be done differently ?


Diffs
-----

  trunk/koffice/karbon/plugins/CMakeLists.txt 948323 
  trunk/koffice/karbon/plugins/effectsfilters/CMakeLists.txt PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/FilterEffects.h PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/FilterEffects.cpp PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoFilterEffect.h PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoFilterEffect.cpp PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoInvertFilterEffect.h PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoInvertFilterEffect.cpp PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoShapeFilterEffect.h PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoShapeFilterEffect.cpp PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/karbonfiltereffects.rc PRE-CREATION 
  trunk/koffice/libs/flake/KoShapeController.h 948323 
  trunk/koffice/libs/flake/KoShapeController.cpp 948323 

Diff: http://reviewboard.kde.org/r/529/diff


Testing
-------


Thanks,

Cyrille

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]