[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Selecting image when inserting picture shape
From:       jaham () gmx ! net
Date:       2008-11-16 19:22:06
Message-ID: 200811162022.06796.jaham () gmx ! net
[Download RAW message or body]

On Sunday 16 November 2008 10:07:14 Thomas Zander wrote:
> On Friday 14. November 2008 23:43:45 jaham@gmx.net wrote:
> > I took the opportunity to fix a usability which we briefly discussed at
> > the last KOffice meeting. This makes it possible to have a file dialog
> > pop up when a picture shape is inserted into a document. To not have the
> > file dialog shown in the shape properties docker i added a new function
> > KoShapeConfigWidgetBase::showOnShapeSelect which controls if a shape
> > config widget is shown inside the shape properties docker when the
> > corresponding shape is selected.
>
> Hi,
>
> Thanks for working on this!
>
> Some questions;
>
> You added functionality to the shape properties docker. Which is not
> enabled per default. Would that functionality to show the file dialog not
> be better fitting in the tool properties docker?
>
> The configWidgetBase has the API showOnShapeCreate(). Which is indeed
> different, yet similar to your new showOnShapeSelect().
> Would it be possible to just reuse that method and way of working instead
> of introducting a new feature?

Thanks for your feedback. I think there is something i have to explain what i 
did to implement the feature.
The shape properties docker had the feature to basically show the first of the 
available shape config widgets of a selected shape. What i changed is that a 
shape config widget could choose _not_ to be shown there.
Let me explain the reason for that. For the selection of the image i used a 
shape config widget which is shown on shape creation. As there was no other 
PictureShape config widget before, the new one would show up in the shape 
properties docker automatically when selecting a picture shape. That's why i 
introduced the new method showOnShapeSelect() so the file selection widget 
would not be shown inside the shape properties docker. My first idea was to use 
an enum for these two showOn* methods but that would have meant a lot of 
changes all over the place.
Hope that makes my intentions more clear. 
If there is a better way doing that, i would be glad to implement it.

Ciao Jan


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]