[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Selecting image when inserting picture shape
From:       "C. Boemann" <cbr () boemann ! dk>
Date:       2008-11-16 10:32:36
Message-ID: 200811161132.36829.cbr () boemann ! dk
[Download RAW message or body]

On Sunday 16 November 2008 10:09:10 Thomas Zander wrote:
> On Saturday 15. November 2008 00:04:15 jaham@gmx.net wrote:
> > On Friday 14 November 2008 23:56:52 Cyrille Berger wrote:
> > > Hi
> > >
> > > I am not sure if I understood correctly what you did.
> > > But didn't we say that the dialog only be shown when you first insert
> > > the image ? And then, when the shape is on the canvas the docker 
would
> > > be used to change the image ? Is that what your patch is doing ?
> >
> > Yes it does show the dialog when first inserting the shape. The tool
> > docker is used like before to change the image afterwards when the 
shape
> > is on canvas.
>
> Oh, if thats the approach you aimed for then this is in line with the
> showOnShapeCreate() virtual method's goal.
> I don't think you need to introduce the new feature showOnShapeSelect
> then :)
I basically have the same concerns about the technicalities as Thomas have 
voiced.

I'm very glad about this work, and really hope that it will get in. I think 
it's an important thing to have a smoother way of inserting an image.

best regards
Casper
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]