[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: First small contribution!
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2008-10-29 15:58:51
Message-ID: 200810291658.52180.inge () lysator ! liu ! se
[Download RAW message or body]

On Tuesday 28 October 2008 21:33:36 Thomas Zander wrote:
> Hi, and thank you for your contribution.
>
> I looked at it and I think its a great first patch. :)
>
> I have some suggestions on the patch itself;
> * you used the documentation for QSpinner, which I pointed you to as I
> recall.
> Unfortunately I was mistaken about the component, it actually is a
> KoUnitDoubleSpinBox [1]. This means the signal doesn't fully match.
> I think we need something like
>    connect( positionXSpinBox, SIGNAL( valueChangedPt(qreal) ),
>    this, SLOT( positionHasChanged() ) );

Heh, I don't think so. :-)  At least the signatures should match, shouldn't 
they ( "(qreal)" vs "()" )?  Maybe it's just a case of forgotten qreal in the 
second case.

	-Inge

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]