[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: First small contribution!
From:       Thomas Zander <zander () kde ! org>
Date:       2008-10-28 20:33:36
Message-ID: 200810282133.36492.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi, and thank you for your contribution.

I looked at it and I think its a great first patch. :)

I have some suggestions on the patch itself;
* you used the documentation for QSpinner, which I pointed you to as I 
recall.
Unfortunately I was mistaken about the component, it actually is a 
KoUnitDoubleSpinBox [1]. This means the signal doesn't fully match.
I think we need something like 
   connect( positionXSpinBox, SIGNAL( valueChangedPt(qreal) ), 
   this, SLOT( positionHasChanged() ) );

* There is a good way to make it easier to communicate your contribution by 
only sending the actual changes you made instead of the whole file.
What you can do is type
  svn diff > myPatch.diff
and attach the file myPatch.diff to the mail for us.

Would you be able to update your patch with these suggestions?
Thanks!

1) 
http://www.koffice.org/developer/apidocs/libs/classKoUnitDoubleSpinBox.html

On Tuesday 28. October 2008 14:00:55 saunierthibault@gmail.com wrote:
> I talked with some of you on the irc and you asked me to work on
> defaultToolWidget to "make the object respond directly to spinbox
> changes, not only when loosing focus"
>
> I just send you the file (It's the newest one from svn...) with the
> litle changes (hope it's what you wanted...).
>
> If you have any task to ask me...tell me!
-- 
Thomas Zander

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]