[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: merge pagestyle changes back to trunk
From:       Pierre <pinaraf () pinaraf ! info>
Date:       2008-08-12 8:04:20
Message-ID: 200808121004.20983.pinaraf () pinaraf ! info
[Download RAW message or body]

On Tuesday 12 August 2008 09:49:52 Thomas Zander wrote:
> On Monday 11. August 2008 17:40:17 Pierre wrote:
> > > Unit tests :)   I noted that at least one didn't compile, I'd like it if
> > > we can even make them pass.
> >
> > Now they compile, but they may segfault/fail... Work in progress...
> > But I think that it's already enough for the merge, isn't it ?
>
> Still doesn't compile for me; did you try with a clean install dir?
>
> Scanning dependencies of target KWordTestBasicLayout
> [ 93%] Building CXX object
> kword/part/frames/tests/CMakeFiles/KWordTestBasicLayout.dir/TestBasicLayout
>.o In file included from
> /home/zander/work/kde/koffice/kword/part/KWDocument.h:28, from
> /home/zander/work/kde/koffice/kword/part/frames/tests/TestBasicLayout.cpp:1
>0: /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:22:24:
> error: KoZoomMode.h: No such file or directory In file included from
> /home/zander/work/kde/koffice/kword/part/KWDocument.h:28, from
> /home/zander/work/kde/koffice/kword/part/frames/tests/TestBasicLayout.cpp:1
>0: /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:65: error:
> ‘KoZoomMode' has not been declared
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:65: error:
> expected ‘,' or ‘...' before ‘mode'
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:70: error:
> ‘KoZoomMode' has not been declared
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:70: error:
> ISO C++ forbids declaration of ‘Mode' with no type
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:70: error:
> expected ‘;' before ‘zoomMode'
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:72: error:
> expected `;' before ‘double'
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:80: error:
> ‘KoZoomMode' has not been declared
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:80: error:
> ISO C++ forbids declaration of ‘Mode' with no type
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:80: error:
> expected ‘;' before ‘m_zoomMode'
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h: In member
> function ‘void KWApplicationConfig::setZoomMode(int)':
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:65: error:
> ‘m_zoomMode' was not declared in this scope
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:65: error:
> ‘mode' was not declared in this scope
> /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h: At global
> scope: /home/zander/work/kde/koffice/kword/part/KWApplicationConfig.h:65:
> warning: unused parameter ‘Mode' make[2]: ***
> [kword/part/frames/tests/CMakeFiles/KWordTestBasicLayout.dir/TestBasicLayou
>t.o] Error 1 make[1]: ***
> [kword/part/frames/tests/CMakeFiles/KWordTestBasicLayout.dir/all] Error 2
> make: *** [all] Error 2
You must make sure you called make in the libs folder first. This is part of 
the Sebastian changes of yesterday evening...

> To answer if you can integrate while the test fails;  well, I'm thinking
> the main reason we have unit tests is to make sure we don't have
> regressions. 
The problem is just that tests are wrong, and must be rewritten. They rely on 
things that don't exist anymore.
> Ignoring a test if it fails should be something that feels
> very wrong to all of us, so please do make sure all relevant tests pass,
> there is no problem with waiting a couple more days with the integration,
> right?
The test is failing because it's outdated, I know it can give bad feelings but 
I don't see why it should delay the branch merge. And waiting for the merge is 
just making it harder for me to work on other parts of KWord (I don't want to 
maintain & recompile two koffice checkouts at the same time, it's gonna create 
problems).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]