[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Bug 76757 : modification of style manager
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-07-27 4:45:58
Message-ID: 200407270645.59890.nicolasg () snafu ! de
[Download RAW message or body]

On Monday 26 July 2004 13:39, p.stirnweiss_koffice@bluewin.ch wrote:
> >-- Message original --
>
> From: Nicolas Goutte <nicolasg@snafu.de>
>
> >To: For developer's discussion about KOffice <koffice-devel@mail.kde.org>
> >Date: Sun, 25 Jul 2004 15:54:46 +0200
> >Subject: Re: Bug 76757 : modification of style manager
> >Reply-To: For developer's discussion about KOffice
> > <koffice-devel@mail.kde.org>
> >
> >On Sunday 25 July 2004 15:41, p.stirnweiss_koffice@bluewin.ch wrote:
> >> >-- Message original --
> >>
> >> From: Nicolas Goutte <nicolasg@snafu.de>
> >>
> >> >To: For developer's discussion about KOffice
> >> > <koffice-devel@mail.kde.org> Date: Sun, 25 Jul 2004 14:52:42 +0200
> >> >Subject: Re: Bug 76757 : modification of style manager
> >> >Reply-To: For developer's discussion about KOffice
> >> > <koffice-devel@mail.kde.org>
> >> >
> >> >On Sunday 25 July 2004 10:50, p.stirnweiss_koffice@bluewin.ch wrote:
> >> >> >-- Message original --
> >> >>
> >> >> From: Nicolas Goutte <nicolasg@snafu.de>
> >> >>
> >> >> >To: For developer's discussion about KOffice
> >> >> > <koffice-devel@mail.kde.org> Date: Sat, 24 Jul 2004 23:36:52 +0200
> >> >> >Subject: Re: Bug 76757 : modification of style manager
> >> >> >Reply-To: For developer's discussion about KOffice
> >> >> > <koffice-devel@mail.kde.org>
> >> >> >
> >> >> >On Saturday 24 July 2004 19:07, p.stirnweiss_koffice@bluewin.ch 
wrote:
> >> >> >> Hi, I am starting to have a look at this one.
> >> >> >> I would like to change some stuff in the way the style manager is
> >> >> >> organised. Let me know your opinions on these ideas (I personaly
> >
> >find
> >
> >> >> them
> >> >>
> >> >> >> more logical, but it may not look the same to everybody):
> >> >> >
> >> >> >The problem of splitting dialogs is that it is only good if it is
>
> not
>
> >> >done
> >> >
> >> >> >only in the stylist but also in each of the individual dialogs.
> >> >> > (Especially
> >> >> >
> >> >> >for the points 2 and 3 below.)
> >> >
> >> >I want to add to my comment here, that it is also important, as KWord
> >
> >is
> >
> >> >supposed to get character styles soon and possibly the stylist dialog
> >> > should
> >> >
> >> >be modified having this idea in mind too.
> >>
> >> Wow, this seems to evolve way beyond my current level of understanding.
> >
> >I
> >
> >> am not sure it is Junior level anymore :).
> >
> >Well, I had always doubts about marking this bug as Junior Job due to the
> >
> >Stylist, but I did anyway. :-)
> >
> >To be serious again: I do not mean that you need to do it. I just want to
> >tell
> >that layout (paragraph formatting) and character formatting have to be
> > kept
> >
> >separated due to this. (Image layout dialogs being greyed out for
> > character
> >
> >styles.)
> >
> >> Anyway, I have a patch that only move the Font position to the Font
> >> effect tab. This solve the Format/Font dialog in 800x600 all together.
> >> And make the Style manager just a bit to big (height wise) but the
> >> buttons (OK,Cancel...) are now reachable. I do not know if this patch is
> >> interesting if the whole thing is going to have a face lift anyway.
> >
> >Fix the bug first. (As we have not too much developers, it always possible
> >
> >that the changes would be for after KOffice 1.4.)
>
> OK. Here is a patch (bug76757...dif) that transfers the Font position to
> the font effect tab. This reduces the height of the style manager. It is
> still a bit too big, but the buttons are reachable in 800x600 with the
> panel normal size. It also fixes the format/font dialog. In order to reduce
> the height of this dialog more, there are two tabs that need work : font
> effect (a bit) and mainly Indent and spacing.
> The format/paragraph is about the same (usable but a little bit big), this
> is also due to indent and spacing.
> Configure autocorrect seems allright to me, as well as configure Kword.

I have committed that too.

(By the way, it seems that KWord has a bug in the style manager, as the style 
names are not shown anymore. However as KDE Bugs is currently broken, I 
cannot report it now. (Therefore this note.))

>
> So the bug is not entirely fixed but at least the dialog boxes are now
> usable.
>
> Once again, this is my second piece of programming so please make sure I
> have not broken anything. The software compiles, and the functionality
> seems to work OK (both in style manager and in individual format font
> dialog).
(...)

Have a nice day!

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]