[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] KoText date/time format history
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2003-09-19 18:33:05
[Download RAW message or body]

On Friday 19 September 2003 10:15, Thomas Zander wrote:
> On Thursday 18 September 2003 20:37, Nicolas Goutte wrote:
> > The attached patch is for the file koffice/lib/kotext/kovariable.cc
> >
> > It fixes the format history of date or time variables by not shoeing the
> > locale date/time formats. (This is bug#64474)
>
> What is 'shoeing' ?

Sorry, I meant "showing" (e is the neighbour of w on the keyboard.)

>
> You asked
> -        if(i==0) selectLast = true;
> +       if (i==0)
> +          selectLast = true; // ###: what is that supposed to be good for?
>
> The Locale entry is always the first one (since its one of the entries you
> are not allowed to alter) and it is a (localizable) default string.
> The idea was not to save the entry to the history so it will not be added
> to the history part of the combobox later.

Yes, this is what did not work anymore and what I have fixed. But then why 
select the last element? 

I could understand selecting the first one, as it is the locale but not the 
last one. And only if the locale element is the last one (and not the first)  
in history, therefore the last used by the user.

> The reason this is done seperately is because the string is localizable and
> can change.

Sure!

> Default time formats also added to the combo that should not be saved can
> be string compared, while this one can not.

There are all saved, they are only not shown again on load.

>
> I don't understand what is wrong with the current approuch (and I don't
> understand the bug report either)  an "I expected" and an "but I got" would
> have been nice.

The bug report is that "locale", written so and not localized, is shown 
without the patch. (I found out that this bug is already in KOffice 1.2.)

>
> > The change abaout the variable selectLast are because I misunderstood
> > what the variable emant. However, I have still not understood what
> > behaviour is intended with this variable. (Why select the last format
> > only if the locale format is the first in history? Sorry, but I cannot
> > find any reason why.)
>
> I don't know for sure; but this migh have to do with the problem that KWord
> has for some time saved the locale to the history; while it certainly
> should not do so.

Meanwhile I suppose that the reason was to selecte the last element used. But 
the implementation needs to be another to have that.

> This can probably be removed.

Yes, I think that it will be the best for KOffice 1.3. I will just add a 
comment about adding a "select last element used" at load.

Have a nice day!

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]