[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] KoText date/time format history
From:       Thomas Zander <zander () microweb ! nl>
Date:       2003-09-19 8:15:39
[Download RAW message or body]

On Thursday 18 September 2003 20:37, Nicolas Goutte wrote:
> The attached patch is for the file koffice/lib/kotext/kovariable.cc
>
> It fixes the format history of date or time variables by not shoeing the
> locale date/time formats. (This is bug#64474)

What is 'shoeing' ?

You asked
-        if(i==0) selectLast = true;
+       if (i==0)
+          selectLast = true; // ###: what is that supposed to be good for?

The Locale entry is always the first one (since its one of the entries you 
are not allowed to alter) and it is a (localizable) default string.
The idea was not to save the entry to the history so it will not be added to 
the history part of the combobox later.
The reason this is done seperately is because the string is localizable and 
can change.
Default time formats also added to the combo that should not be saved can be 
string compared, while this one can not.

I don't understand what is wrong with the current approuch (and I don't 
understand the bug report either)  an "I expected" and an "but I got" would 
have been nice.

> The change abaout the variable selectLast are because I misunderstood
> what the variable emant. However, I have still not understood what
> behaviour is intended with this variable. (Why select the last format
> only if the locale format is the first in history? Sorry, but I cannot
> find any reason why.)
I don't know for sure; but this migh have to do with the problem that KWord 
has for some time saved the locale to the history; while it certainly 
should not do so.
This can probably be removed.

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]